You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2022/04/01 13:53:01 UTC

[GitHub] [incubator-shenyu-dashboard] daiwenyu commented on a change in pull request #195: page navigation bug (#180)

daiwenyu commented on a change in pull request #195:
URL: https://github.com/apache/incubator-shenyu-dashboard/pull/195#discussion_r840607692



##########
File path: src/routes/Plugin/Common/index.js
##########
@@ -164,15 +163,16 @@ export default class Common extends Component {
     const { plugins } = this.props;
     this.setState({ selectorPage: 1 });
     this.getAllSelectors(1, plugins);
-  }
+  };
 
   addSelector = () => {
     const { selectorPage } = this.state;
     const { dispatch, plugins } = this.props;
-    let name = this.props.match.params ? this.props.match.params.id : ''
+    let name = this.props.match.params ? this.props.match.params.id : "";
     const plugin = this.getPlugin(plugins, name);
-    const {id: pluginId, config } = plugin;
-    const multiSelectorHandle = this.getPluginConfigField(config, "multiSelectorHandle") === "1";

Review comment:
       this is my point




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org