You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@predictionio.apache.org by HyukjinKwon <gi...@git.apache.org> on 2016/08/03 01:37:49 UTC
[GitHub] incubator-predictionio pull request #265: [PIO-16] Fix Github links correctl...
GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/incubator-predictionio/pull/265
[PIO-16] Fix Github links correctly across documentation
This PR changes Github links correctly across documentation.
Mainly the change is,
- from: `https://github.com/`**`PredictionIO/PredictionIO`**`/...`
- to: `https://github.com/`**`apache/incubator-predictionio`**`/...`
Also, this fixes the main branch from `master` to `develop` in those link. For example,
- from: `https://github.com/PredictionIO/PredictionIO/commits/`**`master`**
- to: `https://github.com/apache/incubator-predictionio/commits/`**`develop`**
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HyukjinKwon/incubator-predictionio PIO-16
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-predictionio/pull/265.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #265
----
commit 7f94bd66bb444e8103f50a306dc0a972206a5824
Author: hyukjinkwon <gu...@gmail.com>
Date: 2016-08-03T01:28:05Z
Fix Github links correctly
commit 856de1025e806e8803b04e1632de56289ae57493
Author: hyukjinkwon <gu...@gmail.com>
Date: 2016-08-03T01:29:40Z
Fix line number for a link
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio issue #265: [PIO-16] Fix Github links correctly acros...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/incubator-predictionio/pull/265
Thanks for kind explanation. I will keep in mind!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio pull request #265: [PIO-16] Fix Github links correctl...
Posted by dszeto <gi...@git.apache.org>.
Github user dszeto commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/265#discussion_r73285727
--- Diff: RELEASE.md ---
@@ -4,15 +4,15 @@
###v0.9.6
-November, 2015 | [Release Notes](https://github.com/PredictionIO/PredictionIO/blob/master/RELEASE.md) have been moved to Github and you are reading them. For a detailed list of commits check [this page](https://github.com/PredictionIO/PredictionIO/commits/master)
+November, 2015 | [Release Notes](https://github.com/apache/incubator-predictionio/blob/develop/RELEASE.md) have been moved to Github and you are reading them. For a detailed list of commits check [this page](https://github.com/apache/incubator-predictionio/commits/develop)
--- End diff --
@HyukjinKwon Release notes should refer to stable sources, so we should use `master`'s `RELEASE.md`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio issue #265: [PIO-16] Fix Github links correctly acros...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/incubator-predictionio/pull/265
FYI, `https://github.com/apache/incubator-predictionio/commits/v0.9.5` is broken.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio issue #265: [PIO-16] Fix Github links correctly acros...
Posted by dszeto <gi...@git.apache.org>.
Github user dszeto commented on the issue:
https://github.com/apache/incubator-predictionio/pull/265
@HyukjinKwon `master` has always been present. It's used for stable release sources. It follows the model described here: http://nvie.com/posts/a-successful-git-branching-model/. Please continue using `develop`.
We will have a discussion on dev@predictionio.incubator.apache.org regarding migrating previous tags to the new repo. Thanks for pointing that out!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio issue #265: [PIO-16] Fix Github links correctly acros...
Posted by dszeto <gi...@git.apache.org>.
Github user dszeto commented on the issue:
https://github.com/apache/incubator-predictionio/pull/265
Build failed due to a network glitch on Travis. Changed files should not affect test. Merging. Thanks @HyukjinKwon !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio issue #265: [PIO-16] Fix Github links correctly acros...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/incubator-predictionio/pull/265
Hi @dszeto , I just realised that master branch was created now (I remember we don't have this before). Do you intend to use this as a main branch and merge develop one to master? In that case I should change the links here to point master branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio pull request #265: [PIO-16] Fix Github links correctl...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-predictionio/pull/265
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---