You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by hl...@apache.org on 2011/04/10 03:54:41 UTC
svn commit: r1090731 - in
/tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal:
ModuleImpl.java services/PropertyShadowBuilderImpl.java
Author: hlship
Date: Sun Apr 10 01:54:41 2011
New Revision: 1090731
URL: http://svn.apache.org/viewvc?rev=1090731&view=rev
Log:
TAP5-853: Make use of new introducePrivateMethod() on PlasticClass when creating various types of proxies
Modified:
tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/ModuleImpl.java
tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/PropertyShadowBuilderImpl.java
Modified: tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/ModuleImpl.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/ModuleImpl.java?rev=1090731&r1=1090730&r2=1090731&view=diff
==============================================================================
--- tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/ModuleImpl.java (original)
+++ tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/ModuleImpl.java Sun Apr 10 01:54:41 2011
@@ -508,10 +508,8 @@ public class ModuleImpl implements Modul
final PlasticField tokenField = plasticClass.introduceField(ServiceProxyToken.class, "token").inject(
token);
- // TODO: Choose a simpler name, unless it conflicts with a service interface method name.
-
- PlasticMethod delegateMethod = plasticClass.introduceMethod(new MethodDescription(Modifier.PRIVATE,
- serviceInterface.getName(), "_$delegate", null, null));
+ PlasticMethod delegateMethod = plasticClass.introducePrivateMethod(serviceInterface.getName(),
+ "delegate", null, null);
// If not concerned with efficiency, this might be done with method advice instead.
delegateMethod.changeImplementation(new InstructionBuilderCallback()
Modified: tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/PropertyShadowBuilderImpl.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/PropertyShadowBuilderImpl.java?rev=1090731&r1=1090730&r2=1090731&view=diff
==============================================================================
--- tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/PropertyShadowBuilderImpl.java (original)
+++ tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/PropertyShadowBuilderImpl.java Sun Apr 10 01:54:41 2011
@@ -69,8 +69,8 @@ public class PropertyShadowBuilderImpl i
{
final PlasticField sourceField = plasticClass.introduceField(sourceClass, "source").inject(source);
- PlasticMethod delegateMethod = plasticClass.introduceMethod(new MethodDescription(Modifier.PRIVATE,
- propertyType.getName(), "_$readProperty", null, null));
+ PlasticMethod delegateMethod = plasticClass.introducePrivateMethod(propertyType.getName(),
+ "readProperty", null, null);
// You don't do this using MethodAdvice, because then we'd have to use reflection to access the read
// method.