You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/18 00:05:01 UTC

[GitHub] [airflow] turbaszek opened a new issue #11625: Use named volumes in breeze

turbaszek opened a new issue #11625:
URL: https://github.com/apache/airflow/issues/11625


   **Description**
   
   Currently, breeze uses unnamed volumes for persisting data (mysql redis, postgres). It would be nice to have named volumes so users can easily delete them.
   
   Example for redis:
   ```yaml
   version: "2.2"
   services:
     redis:
       image: redis:5.0.1
       volumes:
         - /dev/urandom:/dev/random   # Required to get non-blocking entropy source
         - breeze-redis:/data
     airflow:
       environment:
         - INTEGRATION_REDIS=true
       depends_on:
         - redis
   
   volumes:
     # named volumes can be managed easier using docker-compose
     breeze-redis:
   ```
   
   **Use case / motivation**
   
   Easier maintenance of docker volumes.
   
   **Related Issues**
   
   N/A


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on issue #11625: Use named volumes in breeze

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #11625:
URL: https://github.com/apache/airflow/issues/11625#issuecomment-711144156


   For now deleting all the data from all volumes is done via `breeze stop`. This is "all-or-nothing" approach though. With named volues I am not sure if we won't have to manually delete such volumes additionally in "stop" command. Something to be checked but I am generally in favour of this approach. We had recently someone on slack asking about deletion of DB volumes in Breeze, so this might be a good idea to have.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on issue #11625: Use named volumes in breeze

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #11625:
URL: https://github.com/apache/airflow/issues/11625#issuecomment-711145782


   Yep. As I thought. When you run "docker compose down', the named volumes are not deleted. So we can change it to named volumes, but we need to have a way to manage those volumes and have an easy (and default) way to stop and start from the scratch. I think about adding additional flag --preserve-volumes to keep them if we do not want  to delete them. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk closed issue #11625: Use named volumes in breeze

Posted by GitBox <gi...@apache.org>.
potiuk closed issue #11625:
URL: https://github.com/apache/airflow/issues/11625


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org