[jira] [Commented] (AIRFLOW-1523) Clicking on Graph View should display related DAG run

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16910675#comment-16910675 ] 

ASF GitHub Bot commented on AIRFLOW-1523:
-----------------------------------------

JCoder01 commented on pull request #5866: [AIRFLOW-1523] Clicking on Graph View should display related DAG run
URL: https://github.com/apache/airflow/pull/5866
 
 
   Add execution_date_arg
   Use execution_date_arg in graph, gantt, and Back To {parent.dag} links.
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-1523
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
     - In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   Currently, in the dag view, execution_date is not included as query param for the Graph or Gantt Chart views. It also is not included as part of the Back To {{ parentdag }} link. This PR adds execution_date to the query params;
   
   Before:
   
   ![image](https://user-images.githubusercontent.com/651639/63283505-62754b00-c27f-11e9-8fa8-b7997617f13d.png)
   
   After:
   
   ![image](https://user-images.githubusercontent.com/651639/63292214-2b109980-c293-11e9-916d-e93fc80da04b.png)
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   Current tests cover changes
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
   ### Code Quality
   
   - [x] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Clicking on Graph View should display related DAG run
> -----------------------------------------------------
>
>                 Key: AIRFLOW-1523
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-1523
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: ui
>            Reporter: Gediminas Rapolavicius
>            Assignee: James Coder
>            Priority: Minor
>              Labels: easy-fix, webapp
>         Attachments: Screen Shot 2017-08-20 at 10.09.16 PM.png
>
>
> When you are looking at the logs of a task instance (and you got there from tree view, etc, see the screenshot), clicking on Graph View will take you to the Graph View of the latest DAG run.
> It's very hard to navigate from task instance logs to the related Graph View, so you could see logs of other tasks in the same run, etc.
> I am proposing to change the Graph View link, so that it would take to the Graph View of the same run as the task instance, not the latest.
> I could try to implement this, if the maintainers think that it would useful and could be merged.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)