You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by zw...@apache.org on 2020/02/11 23:40:05 UTC

[trafficserver] branch 9.0.x updated: Remove unnecesary HttpSM handler call with VC_EVENT_ERROR

This is an automated email from the ASF dual-hosted git repository.

zwoop pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/trafficserver.git


The following commit(s) were added to refs/heads/9.0.x by this push:
     new 243b26f  Remove unnecesary HttpSM handler call with VC_EVENT_ERROR
243b26f is described below

commit 243b26fb57c6baee02650c7beb64c3afef1903a3
Author: Masaori Koshiba <ma...@apache.org>
AuthorDate: Fri Jan 31 16:25:39 2020 +0900

    Remove unnecesary HttpSM handler call with VC_EVENT_ERROR
    
    (cherry picked from commit 240bb69f83d0111d96352af3104a4bdff88fd2e8)
---
 proxy/http2/Http2Stream.cc | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/proxy/http2/Http2Stream.cc b/proxy/http2/Http2Stream.cc
index daa62ad..6b6b695 100644
--- a/proxy/http2/Http2Stream.cc
+++ b/proxy/http2/Http2Stream.cc
@@ -459,7 +459,6 @@ Http2Stream::initiating_close()
 
     // This should result in do_io_close or release being called.  That will schedule the final
     // kill yourself signal
-    // Send the SM the EOS signal if there are no active VIO's to signal
     // We are sending signals rather than calling the handlers directly to avoid the case where
     // the HttpTunnel handler causes the HttpSM to be deleted on the stack.
     bool sent_write_complete = false;
@@ -486,9 +485,6 @@ Http2Stream::initiating_close()
         Http2StreamDebug("send EOS to read cont");
         read_event = send_tracked_event(read_event, VC_EVENT_EOS, &read_vio);
       }
-    } else if (_sm) {
-      SCOPED_MUTEX_LOCK(lock, _sm->mutex, this_ethread());
-      _sm->handleEvent(VC_EVENT_ERROR);
     } else if (!sent_write_complete) {
       // Transaction is already gone or not started. Kill yourself
       do_io_close();