You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2026/09/04 17:31:08 UTC
[PR] test(treemap): pin border-free labels so tiles render without seams [superset]
rusackas opened a new pull request, #43890:
URL: https://github.com/apache/superset/pull/43890
### SUMMARY
Regression test for the Treemap "vertical line inside every tile" symptom reported in #43862.
The line came from a 1px `borderColor`/`borderWidth` on the label style. ECharts sizes the label's text box to the full node height (via the treemap view's `beforeUpdate` hook), so the box border rendered as a vertical line right after the label text, spanning the whole tile. #37808 removed the border and the symptom is gone on `master` (the reporter's screenshot also shows the inter-node gaps that #40181 removed, so their build predates both fixes; the border was still present in the 6.0.0 release).
Nothing pinned that fix, so this adds a test that walks every `label` / `upperLabel` style in the transformed options (series, emphasis, levels, upper labels, and the filtered-node label) and asserts none of them declares a border. Verified the test fails if the old `borderColor`/`borderWidth` pair is reintroduced on `labelProps`, and passes on `master`.
Rendered the pre-#37808 options with both ECharts 5.6.0 and 6.1.0 to confirm the mechanism; both draw the same line the reporter sees:
<img width="760" alt="treemap label border artifact" src="https://github.com/user-attachments/assets/f4de4d10-a91b-4c39-8867-8664c47c4ef8" />
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A, test-only.
### TESTING INSTRUCTIONS
```
cd superset-frontend
npx jest --runInBand plugins/plugin-chart-echarts/test/Treemap/transformProps.test.ts
```
To see it fail, add `borderColor: theme.colorBgBase, borderWidth: 1` back to `labelProps` in `src/Treemap/transformProps.ts`.
### ADDITIONAL INFORMATION
- [x] Has associated issue: #43862 (already fixed on `master` by #37808; this pins it)
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
🤖 Generated with [Claude Code](https://claude.com/claude-code)
https://claude.ai/code/session_015XdpWLXhUs7r8d4F2R5D6F
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] test(treemap): pin border-free labels so tiles render without seams [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #43890:
URL: https://github.com/apache/superset/pull/43890#issuecomment-5545136248
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/43890?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 79.45%. Comparing base ([`e1ce6b6`](https://app.codecov.io/gh/apache/superset/commit/e1ce6b601c048c2f5bf754a0292d7e774ee43873?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b0c8c7b`](https://app.codecov.io/gh/apache/superset/commit/b0c8c7bf3ace169d1acc29a3f4bbe5dba203d616?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #43890 +/- ##
=======================================
Coverage 79.45% 79.45%
=======================================
Files 2895 2895
Lines 168167 168167
Branches 38995 38995
=======================================
+ Hits 133616 133623 +7
+ Misses 32052 32045 -7
Partials 2499 2499
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/43890/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [javascript](https://app.codecov.io/gh/apache/superset/pull/43890/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `75.01% <ø> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/43890?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] test(treemap): pin border-free labels so tiles render without seams [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43890:
URL: https://github.com/apache/superset/pull/43890#issuecomment-5544195787
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] test(treemap): pin border-free labels so tiles render without seams [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #43890:
URL: https://github.com/apache/superset/pull/43890
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org