[GitHub] [accumulo] cshannon commented on a diff in pull request #2992: Improve output and user experience of accumulo admin utilities

[GitBox <gi...@apache.org>]

cshannon commented on code in PR #2992:
URL: https://github.com/apache/accumulo/pull/2992#discussion_r985822389


##########
server/base/src/main/java/org/apache/accumulo/server/util/DeleteZooInstance.java:
##########
@@ -103,6 +112,19 @@ private static void cleanAllOld(ServerContext context, final ZooReaderWriter zk)
     }
   }
 
+  private static boolean checkCurrentInstance(ServerContext context, String instanceName,
+      String instanceId) {
+    if (instanceId.equals(context.getInstanceID().canonical())) {
+      String prompt = String.valueOf(
+          System.console().readLine("Warning: This is the current instance, are you sure? Y/n: "));
+      if (prompt == null || !prompt.equals("Y")) {

Review Comment:
   I agree 100% and will change it. I didn't know if we had other examples of confirm prompts but I should have searched because I agree that it should be made consistent and match if we already have a normal pattern for prompting the user for yes/no.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org