You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tinkerpop.apache.org by "Divij Vaidya (Jira)" <ji...@apache.org> on 2020/06/04 03:36:00 UTC

[jira] [Created] (TINKERPOP-2380) Add tests to validate correct handler order in server

Divij Vaidya created TINKERPOP-2380:
---------------------------------------

             Summary: Add tests to validate correct handler order in server
                 Key: TINKERPOP-2380
                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2380
             Project: TinkerPop
          Issue Type: Improvement
          Components: server
            Reporter: Divij Vaidya


This task is to add validation mechanisms in the code so that issues such as https://issues.apache.org/jira/browse/TINKERPOP-2374 can be proactively caught in the future. 

There are two mechanisms that can be created to validate handler order:
1. Add logic to validate that the pipeline has been setup at runtime. We might want to leverage the [finalize method in AbstractChannelizer|https://github.com/apache/tinkerpop/blob/cc3c5cb83e253b9949076628a7cfaade7f86f40e/gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/AbstractChannelizer.java#L124]. Note that this wouldn't catch pipeline setup issues where it is modified dynamically based on message information while processing the message.
2. Add tests to validate the pipeline through which a message is executed. It is not easy to do this today and we would need to expose pipeline details to these tests for validation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)