[jira] [Commented] (CALCITE-5748) Support Guava 32.0.0-jre

["Sergey Nuyanzin (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-5748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17729002#comment-17729002 ] 

Sergey Nuyanzin commented on CALCITE-5748:
------------------------------------------

regarding NPE it is just a consequence...
the real reason is fixing of CVE-2020-8908 on guava level[1] and as a result {{Files#createTempDir}} stopped working on Windows
I raised an issue for that [2] 

{{Files#createTempDir}} is used inside embedded redis server and that's why it started to fail on Windows.
The most distracting thing is that this redis embedded server from one side looks not supported since 2018 and from the other side is not easily extensible...
For that reason need to reimplement 3 classes in PR to override behavior

[1] https://github.com/google/guava/commit/feb83a1c8fd2e7670b244d5afd23cba5aca43284
[2] https://github.com/google/guava/issues/6535

> Support Guava 32.0.0-jre
> ------------------------
>
>                 Key: CALCITE-5748
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5748
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Sergey Nuyanzin
>            Assignee: Sergey Nuyanzin
>            Priority: Major
>
> There is guava 32.0.0 available.
> Besides version change there are a couple of issues:
> 1. Some methods start failing on {{CheckReturnValue}}
> 2. RedisTests start failing with NPE on Windows



--
This message was sent by Atlassian Jira
(v8.20.10#820010)