[GitHub] [sling-org-apache-sling-pipes] npeltier commented on a change in pull request #11: SLING-8648 Move pipe to incorporate ordering of the nodes .

[GitBox <gi...@apache.org>]

npeltier commented on a change in pull request #11: SLING-8648 Move pipe to incorporate ordering of the nodes .
URL: https://github.com/apache/sling-org-apache-sling-pipes/pull/11#discussion_r317057021
 
 

 ##########
 File path: src/main/java/org/apache/sling/pipes/internal/MovePipe.java
 ##########
 @@ -62,24 +67,29 @@ public boolean modifiesContent() {
             String targetPath = getExpr();
             try {
                 Session session = resolver.adaptTo(Session.class);
-                if (session.itemExists(targetPath)){
+                if (orderBefore) {
+                    output = reorder(resource, targetPath, session);
+                } else if (session.itemExists(targetPath)) {
                     if (overwriteTarget && !isDryRun()) {
 
 Review comment:
   i know it's not you, but could you move isDryRun test to after the log is emitted?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services