You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/07/12 07:12:42 UTC
[GitHub] [hudi] zhoulii opened a new pull request, #6083: [DOCS] Fix link rendering error in Docker Demo and some other typos
zhoulii opened a new pull request, #6083:
URL: https://github.com/apache/hudi/pull/6083
## What is the purpose of the pull request
fix link rendering error in Docker Demo and some other typos.
## Verify this pull request
This pull request is a trivial rework without any test coverage.
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] zhoulii commented on pull request #6083: [DOCS] Fix link rendering error in Docker Demo and some other typos
Posted by GitBox <gi...@apache.org>.
zhoulii commented on PR #6083:
URL: https://github.com/apache/hudi/pull/6083#issuecomment-1231106323
Hi @yihua, I add a new commit to solve the conflict (seems not work), and there are three commits for this PR，Do I need to squash these commits?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on pull request #6083: [DOCS] Fix link rendering error in Docker Demo and some other typos
Posted by GitBox <gi...@apache.org>.
yihua commented on PR #6083:
URL: https://github.com/apache/hudi/pull/6083#issuecomment-1231130336
> Hi @yihua, I add a new commit to solve the conflict (seems not work), and there are three commits for this PR，Do I need to squash these commits?
Don't worry about it. I'll do the squash and merge so you don't have to squash the commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua merged pull request #6083: [DOCS] Fix link rendering error in Docker Demo and some other typos
Posted by GitBox <gi...@apache.org>.
yihua merged PR #6083:
URL: https://github.com/apache/hudi/pull/6083
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on a diff in pull request #6083: [DOCS] Fix link rendering error in Docker Demo and some other typos
Posted by GitBox <gi...@apache.org>.
yihua commented on code in PR #6083:
URL: https://github.com/apache/hudi/pull/6083#discussion_r957970464
##########
website/docs/configurations.md:
##########
@@ -3197,7 +3197,7 @@ Configurations that control compaction (merging of log files onto a new base fil
---
> #### hoodie.keep.min.commits
-> Similar to hoodie.keep.max.commits, but controls the minimum number ofinstants to retain in the active timeline.<br></br>
+> Similar to hoodie.keep.max.commits, but controls the minimum number of instants to retain in the active timeline.<br></br>
Review Comment:
I addressed it in #6542.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] zhoulii commented on pull request #6083: [DOCS] Fix link rendering error in Docker Demo and some other typos
Posted by GitBox <gi...@apache.org>.
zhoulii commented on PR #6083:
URL: https://github.com/apache/hudi/pull/6083#issuecomment-1182741144
hi @danny0405 , can you help to review this, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on a diff in pull request #6083: [DOCS] Fix link rendering error in Docker Demo and some other typos
Posted by GitBox <gi...@apache.org>.
yihua commented on code in PR #6083:
URL: https://github.com/apache/hudi/pull/6083#discussion_r957967450
##########
website/docs/configurations.md:
##########
@@ -3197,7 +3197,7 @@ Configurations that control compaction (merging of log files onto a new base fil
---
> #### hoodie.keep.min.commits
-> Similar to hoodie.keep.max.commits, but controls the minimum number ofinstants to retain in the active timeline.<br></br>
+> Similar to hoodie.keep.max.commits, but controls the minimum number of instants to retain in the active timeline.<br></br>
Review Comment:
Please refrain from changing the `configurations.md` directly. This is automatically generated and updated based on the Hudi config classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] zhoulii commented on a diff in pull request #6083: [DOCS] Fix link rendering error in Docker Demo and some other typos
Posted by GitBox <gi...@apache.org>.
zhoulii commented on code in PR #6083:
URL: https://github.com/apache/hudi/pull/6083#discussion_r957972065
##########
website/docs/configurations.md:
##########
@@ -3197,7 +3197,7 @@ Configurations that control compaction (merging of log files onto a new base fil
---
> #### hoodie.keep.min.commits
-> Similar to hoodie.keep.max.commits, but controls the minimum number ofinstants to retain in the active timeline.<br></br>
+> Similar to hoodie.keep.max.commits, but controls the minimum number of instants to retain in the active timeline.<br></br>
Review Comment:
@yihua Thanks for reviewing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org