You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Adrian Cole <ad...@gmail.com> on 2014/10/04 05:19:39 UTC
FYI: I plan to finish the unasyncing this weekend
Many of you know about the removal of the async interfaces. This has been
going on for a while, but it is really important for the long term health
of the project. These interfaces represent code people usually don't want
to touch and stacktraces folks don't want to see.
Eventhough we missed the deprecation-based goal of version 1.7, we
shouldn't punt to 2.x as this work actually sets us up to do something
notable in 2.x.
I understand that in my absence it looked like a hill of work, but I intend
to own finishing this, including removing the complex code that supported
it. I have full confidence I can complete even labs this weekend.
That said, I would appreciate committers watching on irc if github if you
can, as I will need some +1s to finish this off. Unless all providers are
moved off async, I can't remove the debty internal code.. so this is
critical.
Long story short.. hope to see some of you this weekend and let's finish
this thing!
-A
Re: FYI: I plan to finish the unasyncing this weekend
Posted by Adrian Cole <ad...@gmail.com>.
Alright.. final lap.
2 pull requests with a little todos on labs once they are merged.
https://github.com/jclouds/jclouds/pull/555 < remove async from Fallback
https://github.com/jclouds/jclouds/pull/554 < remove io executor
These in, we have completed the most decrufting effort, originally
aimed for 1.6, but hey.. I know I was awol. I'm sure Gaul will check
me, but this is in total somewhere in the order of 10s of thousands of
lines of unwanted code gone this weekend. Now, we can focus on the
code we want!
I'll check in the morning, and if these are a go, I will raise pull
requests to tidy up any of the subordinate repos.
-A
On Sun, Oct 5, 2014 at 9:08 PM, Adrian Cole <ad...@gmail.com> wrote:
> Almost there! So all apis and providers are unasynced. Awaiting a go
> on this one, which *significantly* decomplicates core, and opens us up
> to simplify further.
>
> https://github.com/jclouds/jclouds/pull/553 < remove old school RestContext
>
> As soon as I get a go on above, I'll raise a pull request to remove
> the async from the http layer. At that point, we're pretty much done.
> Only last consideration is whether to unasync Fallbacks since we no
> longer need them to handle futures.
>
> Thanks tons to Ignasi and Andrew P for reviews today!
>
> -A
>
> On Sun, Oct 5, 2014 at 12:04 PM, Adrian Cole <ad...@gmail.com> wrote:
>> Still plodding away on vcloud-director.. almost done.
>>
>> In the mean time, these are the last changes to remove the long
>> deprecated AsyncBlobStore.
>>
>> https://github.com/jclouds/jclouds/pull/547 < remove async blobstore from core
>> https://github.com/jclouds/jclouds-labs-aws/pull/58 < last reference
>> from glacier
>> https://github.com/jclouds/jclouds-labs-google/pull/52 < ^^ gcs
>> https://github.com/jclouds/jclouds-labs-openstack/pull/150 < ^^ openstack-swift
>>
>> https://issues.apache.org/jira/browse/JCLOUDS-40
>>
>> -A
>>
>> On Sat, Oct 4, 2014 at 4:52 PM, Adrian Cole <ad...@gmail.com> wrote:
>>> Thanks to ignasi for fixing the pull request builders and reviewing a slew
>>> of PRs.
>>>
>>> The last provider is labs/vcloud-director. I will do that tonight or
>>> tomorrow, then clean up the core code which will then be no longer used!
>>>
>>> Cheers,
>>> -A
>>>
>>> On Oct 4, 2014 11:39 AM, "Adrian Cole" <ad...@gmail.com> wrote:
>>>>
>>>> PRs fully tested and awaiting merge
>>>>
>>>> https://github.com/jclouds/jclouds-labs-google/pull/51 < remove
>>>> duplicate AsyncBlobStore impl
>>>> https://github.com/jclouds/jclouds-labs-openstack/pull/149 < remove
>>>> duplicate AsyncBlobStore impl
>>>> https://github.com/jclouds/jclouds-labs-aws/pull/57 < unasync glacier
>>>>
>>>> I'll move to jclouds-labs, next, which is the last repo to unasync.
>>>>
>>>> -A
>>>>
>>>> On Fri, Oct 3, 2014 at 11:32 PM, Adrian Cole <ad...@gmail.com>
>>>> wrote:
>>>> > Here's a quick status. Thanks to Andrew Gaul for staying up late
>>>> > reviewing pull requests.
>>>> >
>>>> > jclouds/jclouds <- done!
>>>> > jclouds/jclouds-labs-aws <- pending
>>>> > https://github.com/jclouds/jclouds-labs-aws/pull/57
>>>> > jclouds/jclouds-labs-openstack <- easy switch openstack-swift to
>>>> > blobstore's SubmissionAsyncBlobStore
>>>> > jclouds/jclouds-labs-google <- easy switch google-cloud-storage to
>>>> > blobstore's SubmissionAsyncBlobStore
>>>> > jclouds/jclouds-labs <- bunch of unasyncing, which I'll start (and
>>>> > likely finish) tomorrow.
>>>> >
>>>> > gnight
>>>> >
>>>> >
>>>> > On Fri, Oct 3, 2014 at 8:19 PM, Adrian Cole <ad...@gmail.com>
>>>> > wrote:
>>>> >> Many of you know about the removal of the async interfaces. This has
>>>> >> been
>>>> >> going on for a while, but it is really important for the long term
>>>> >> health of
>>>> >> the project. These interfaces represent code people usually don't want
>>>> >> to
>>>> >> touch and stacktraces folks don't want to see.
>>>> >>
>>>> >> Eventhough we missed the deprecation-based goal of version 1.7, we
>>>> >> shouldn't
>>>> >> punt to 2.x as this work actually sets us up to do something notable in
>>>> >> 2.x.
>>>> >>
>>>> >> I understand that in my absence it looked like a hill of work, but I
>>>> >> intend
>>>> >> to own finishing this, including removing the complex code that
>>>> >> supported
>>>> >> it. I have full confidence I can complete even labs this weekend.
>>>> >>
>>>> >> That said, I would appreciate committers watching on irc if github if
>>>> >> you
>>>> >> can, as I will need some +1s to finish this off. Unless all providers
>>>> >> are
>>>> >> moved off async, I can't remove the debty internal code.. so this is
>>>> >> critical.
>>>> >>
>>>> >> Long story short.. hope to see some of you this weekend and let's
>>>> >> finish
>>>> >> this thing!
>>>> >>
>>>> >> -A
>>>> >>
Re: FYI: I plan to finish the unasyncing this weekend
Posted by Adrian Cole <ad...@gmail.com>.
Almost there! So all apis and providers are unasynced. Awaiting a go
on this one, which *significantly* decomplicates core, and opens us up
to simplify further.
https://github.com/jclouds/jclouds/pull/553 < remove old school RestContext
As soon as I get a go on above, I'll raise a pull request to remove
the async from the http layer. At that point, we're pretty much done.
Only last consideration is whether to unasync Fallbacks since we no
longer need them to handle futures.
Thanks tons to Ignasi and Andrew P for reviews today!
-A
On Sun, Oct 5, 2014 at 12:04 PM, Adrian Cole <ad...@gmail.com> wrote:
> Still plodding away on vcloud-director.. almost done.
>
> In the mean time, these are the last changes to remove the long
> deprecated AsyncBlobStore.
>
> https://github.com/jclouds/jclouds/pull/547 < remove async blobstore from core
> https://github.com/jclouds/jclouds-labs-aws/pull/58 < last reference
> from glacier
> https://github.com/jclouds/jclouds-labs-google/pull/52 < ^^ gcs
> https://github.com/jclouds/jclouds-labs-openstack/pull/150 < ^^ openstack-swift
>
> https://issues.apache.org/jira/browse/JCLOUDS-40
>
> -A
>
> On Sat, Oct 4, 2014 at 4:52 PM, Adrian Cole <ad...@gmail.com> wrote:
>> Thanks to ignasi for fixing the pull request builders and reviewing a slew
>> of PRs.
>>
>> The last provider is labs/vcloud-director. I will do that tonight or
>> tomorrow, then clean up the core code which will then be no longer used!
>>
>> Cheers,
>> -A
>>
>> On Oct 4, 2014 11:39 AM, "Adrian Cole" <ad...@gmail.com> wrote:
>>>
>>> PRs fully tested and awaiting merge
>>>
>>> https://github.com/jclouds/jclouds-labs-google/pull/51 < remove
>>> duplicate AsyncBlobStore impl
>>> https://github.com/jclouds/jclouds-labs-openstack/pull/149 < remove
>>> duplicate AsyncBlobStore impl
>>> https://github.com/jclouds/jclouds-labs-aws/pull/57 < unasync glacier
>>>
>>> I'll move to jclouds-labs, next, which is the last repo to unasync.
>>>
>>> -A
>>>
>>> On Fri, Oct 3, 2014 at 11:32 PM, Adrian Cole <ad...@gmail.com>
>>> wrote:
>>> > Here's a quick status. Thanks to Andrew Gaul for staying up late
>>> > reviewing pull requests.
>>> >
>>> > jclouds/jclouds <- done!
>>> > jclouds/jclouds-labs-aws <- pending
>>> > https://github.com/jclouds/jclouds-labs-aws/pull/57
>>> > jclouds/jclouds-labs-openstack <- easy switch openstack-swift to
>>> > blobstore's SubmissionAsyncBlobStore
>>> > jclouds/jclouds-labs-google <- easy switch google-cloud-storage to
>>> > blobstore's SubmissionAsyncBlobStore
>>> > jclouds/jclouds-labs <- bunch of unasyncing, which I'll start (and
>>> > likely finish) tomorrow.
>>> >
>>> > gnight
>>> >
>>> >
>>> > On Fri, Oct 3, 2014 at 8:19 PM, Adrian Cole <ad...@gmail.com>
>>> > wrote:
>>> >> Many of you know about the removal of the async interfaces. This has
>>> >> been
>>> >> going on for a while, but it is really important for the long term
>>> >> health of
>>> >> the project. These interfaces represent code people usually don't want
>>> >> to
>>> >> touch and stacktraces folks don't want to see.
>>> >>
>>> >> Eventhough we missed the deprecation-based goal of version 1.7, we
>>> >> shouldn't
>>> >> punt to 2.x as this work actually sets us up to do something notable in
>>> >> 2.x.
>>> >>
>>> >> I understand that in my absence it looked like a hill of work, but I
>>> >> intend
>>> >> to own finishing this, including removing the complex code that
>>> >> supported
>>> >> it. I have full confidence I can complete even labs this weekend.
>>> >>
>>> >> That said, I would appreciate committers watching on irc if github if
>>> >> you
>>> >> can, as I will need some +1s to finish this off. Unless all providers
>>> >> are
>>> >> moved off async, I can't remove the debty internal code.. so this is
>>> >> critical.
>>> >>
>>> >> Long story short.. hope to see some of you this weekend and let's
>>> >> finish
>>> >> this thing!
>>> >>
>>> >> -A
>>> >>
Re: FYI: I plan to finish the unasyncing this weekend
Posted by Adrian Cole <ad...@gmail.com>.
Still plodding away on vcloud-director.. almost done.
In the mean time, these are the last changes to remove the long
deprecated AsyncBlobStore.
https://github.com/jclouds/jclouds/pull/547 < remove async blobstore from core
https://github.com/jclouds/jclouds-labs-aws/pull/58 < last reference
from glacier
https://github.com/jclouds/jclouds-labs-google/pull/52 < ^^ gcs
https://github.com/jclouds/jclouds-labs-openstack/pull/150 < ^^ openstack-swift
https://issues.apache.org/jira/browse/JCLOUDS-40
-A
On Sat, Oct 4, 2014 at 4:52 PM, Adrian Cole <ad...@gmail.com> wrote:
> Thanks to ignasi for fixing the pull request builders and reviewing a slew
> of PRs.
>
> The last provider is labs/vcloud-director. I will do that tonight or
> tomorrow, then clean up the core code which will then be no longer used!
>
> Cheers,
> -A
>
> On Oct 4, 2014 11:39 AM, "Adrian Cole" <ad...@gmail.com> wrote:
>>
>> PRs fully tested and awaiting merge
>>
>> https://github.com/jclouds/jclouds-labs-google/pull/51 < remove
>> duplicate AsyncBlobStore impl
>> https://github.com/jclouds/jclouds-labs-openstack/pull/149 < remove
>> duplicate AsyncBlobStore impl
>> https://github.com/jclouds/jclouds-labs-aws/pull/57 < unasync glacier
>>
>> I'll move to jclouds-labs, next, which is the last repo to unasync.
>>
>> -A
>>
>> On Fri, Oct 3, 2014 at 11:32 PM, Adrian Cole <ad...@gmail.com>
>> wrote:
>> > Here's a quick status. Thanks to Andrew Gaul for staying up late
>> > reviewing pull requests.
>> >
>> > jclouds/jclouds <- done!
>> > jclouds/jclouds-labs-aws <- pending
>> > https://github.com/jclouds/jclouds-labs-aws/pull/57
>> > jclouds/jclouds-labs-openstack <- easy switch openstack-swift to
>> > blobstore's SubmissionAsyncBlobStore
>> > jclouds/jclouds-labs-google <- easy switch google-cloud-storage to
>> > blobstore's SubmissionAsyncBlobStore
>> > jclouds/jclouds-labs <- bunch of unasyncing, which I'll start (and
>> > likely finish) tomorrow.
>> >
>> > gnight
>> >
>> >
>> > On Fri, Oct 3, 2014 at 8:19 PM, Adrian Cole <ad...@gmail.com>
>> > wrote:
>> >> Many of you know about the removal of the async interfaces. This has
>> >> been
>> >> going on for a while, but it is really important for the long term
>> >> health of
>> >> the project. These interfaces represent code people usually don't want
>> >> to
>> >> touch and stacktraces folks don't want to see.
>> >>
>> >> Eventhough we missed the deprecation-based goal of version 1.7, we
>> >> shouldn't
>> >> punt to 2.x as this work actually sets us up to do something notable in
>> >> 2.x.
>> >>
>> >> I understand that in my absence it looked like a hill of work, but I
>> >> intend
>> >> to own finishing this, including removing the complex code that
>> >> supported
>> >> it. I have full confidence I can complete even labs this weekend.
>> >>
>> >> That said, I would appreciate committers watching on irc if github if
>> >> you
>> >> can, as I will need some +1s to finish this off. Unless all providers
>> >> are
>> >> moved off async, I can't remove the debty internal code.. so this is
>> >> critical.
>> >>
>> >> Long story short.. hope to see some of you this weekend and let's
>> >> finish
>> >> this thing!
>> >>
>> >> -A
>> >>
Re: FYI: I plan to finish the unasyncing this weekend
Posted by Adrian Cole <ad...@gmail.com>.
Thanks to ignasi for fixing the pull request builders and reviewing a slew
of PRs.
The last provider is labs/vcloud-director. I will do that tonight or
tomorrow, then clean up the core code which will then be no longer used!
Cheers,
-A
On Oct 4, 2014 11:39 AM, "Adrian Cole" <ad...@gmail.com> wrote:
> PRs fully tested and awaiting merge
>
> https://github.com/jclouds/jclouds-labs-google/pull/51 < remove
> duplicate AsyncBlobStore impl
> https://github.com/jclouds/jclouds-labs-openstack/pull/149 < remove
> duplicate AsyncBlobStore impl
> https://github.com/jclouds/jclouds-labs-aws/pull/57 < unasync glacier
>
> I'll move to jclouds-labs, next, which is the last repo to unasync.
>
> -A
>
> On Fri, Oct 3, 2014 at 11:32 PM, Adrian Cole <ad...@gmail.com>
> wrote:
> > Here's a quick status. Thanks to Andrew Gaul for staying up late
> > reviewing pull requests.
> >
> > jclouds/jclouds <- done!
> > jclouds/jclouds-labs-aws <- pending
> > https://github.com/jclouds/jclouds-labs-aws/pull/57
> > jclouds/jclouds-labs-openstack <- easy switch openstack-swift to
> > blobstore's SubmissionAsyncBlobStore
> > jclouds/jclouds-labs-google <- easy switch google-cloud-storage to
> > blobstore's SubmissionAsyncBlobStore
> > jclouds/jclouds-labs <- bunch of unasyncing, which I'll start (and
> > likely finish) tomorrow.
> >
> > gnight
> >
> >
> > On Fri, Oct 3, 2014 at 8:19 PM, Adrian Cole <ad...@gmail.com>
> wrote:
> >> Many of you know about the removal of the async interfaces. This has
> been
> >> going on for a while, but it is really important for the long term
> health of
> >> the project. These interfaces represent code people usually don't want
> to
> >> touch and stacktraces folks don't want to see.
> >>
> >> Eventhough we missed the deprecation-based goal of version 1.7, we
> shouldn't
> >> punt to 2.x as this work actually sets us up to do something notable in
> 2.x.
> >>
> >> I understand that in my absence it looked like a hill of work, but I
> intend
> >> to own finishing this, including removing the complex code that
> supported
> >> it. I have full confidence I can complete even labs this weekend.
> >>
> >> That said, I would appreciate committers watching on irc if github if
> you
> >> can, as I will need some +1s to finish this off. Unless all providers
> are
> >> moved off async, I can't remove the debty internal code.. so this is
> >> critical.
> >>
> >> Long story short.. hope to see some of you this weekend and let's finish
> >> this thing!
> >>
> >> -A
> >>
>
Re: FYI: I plan to finish the unasyncing this weekend
Posted by Adrian Cole <ad...@gmail.com>.
PRs fully tested and awaiting merge
https://github.com/jclouds/jclouds-labs-google/pull/51 < remove
duplicate AsyncBlobStore impl
https://github.com/jclouds/jclouds-labs-openstack/pull/149 < remove
duplicate AsyncBlobStore impl
https://github.com/jclouds/jclouds-labs-aws/pull/57 < unasync glacier
I'll move to jclouds-labs, next, which is the last repo to unasync.
-A
On Fri, Oct 3, 2014 at 11:32 PM, Adrian Cole <ad...@gmail.com> wrote:
> Here's a quick status. Thanks to Andrew Gaul for staying up late
> reviewing pull requests.
>
> jclouds/jclouds <- done!
> jclouds/jclouds-labs-aws <- pending
> https://github.com/jclouds/jclouds-labs-aws/pull/57
> jclouds/jclouds-labs-openstack <- easy switch openstack-swift to
> blobstore's SubmissionAsyncBlobStore
> jclouds/jclouds-labs-google <- easy switch google-cloud-storage to
> blobstore's SubmissionAsyncBlobStore
> jclouds/jclouds-labs <- bunch of unasyncing, which I'll start (and
> likely finish) tomorrow.
>
> gnight
>
>
> On Fri, Oct 3, 2014 at 8:19 PM, Adrian Cole <ad...@gmail.com> wrote:
>> Many of you know about the removal of the async interfaces. This has been
>> going on for a while, but it is really important for the long term health of
>> the project. These interfaces represent code people usually don't want to
>> touch and stacktraces folks don't want to see.
>>
>> Eventhough we missed the deprecation-based goal of version 1.7, we shouldn't
>> punt to 2.x as this work actually sets us up to do something notable in 2.x.
>>
>> I understand that in my absence it looked like a hill of work, but I intend
>> to own finishing this, including removing the complex code that supported
>> it. I have full confidence I can complete even labs this weekend.
>>
>> That said, I would appreciate committers watching on irc if github if you
>> can, as I will need some +1s to finish this off. Unless all providers are
>> moved off async, I can't remove the debty internal code.. so this is
>> critical.
>>
>> Long story short.. hope to see some of you this weekend and let's finish
>> this thing!
>>
>> -A
>>
Re: FYI: I plan to finish the unasyncing this weekend
Posted by Adrian Cole <ad...@gmail.com>.
Here's a quick status. Thanks to Andrew Gaul for staying up late
reviewing pull requests.
jclouds/jclouds <- done!
jclouds/jclouds-labs-aws <- pending
https://github.com/jclouds/jclouds-labs-aws/pull/57
jclouds/jclouds-labs-openstack <- easy switch openstack-swift to
blobstore's SubmissionAsyncBlobStore
jclouds/jclouds-labs-google <- easy switch google-cloud-storage to
blobstore's SubmissionAsyncBlobStore
jclouds/jclouds-labs <- bunch of unasyncing, which I'll start (and
likely finish) tomorrow.
gnight
On Fri, Oct 3, 2014 at 8:19 PM, Adrian Cole <ad...@gmail.com> wrote:
> Many of you know about the removal of the async interfaces. This has been
> going on for a while, but it is really important for the long term health of
> the project. These interfaces represent code people usually don't want to
> touch and stacktraces folks don't want to see.
>
> Eventhough we missed the deprecation-based goal of version 1.7, we shouldn't
> punt to 2.x as this work actually sets us up to do something notable in 2.x.
>
> I understand that in my absence it looked like a hill of work, but I intend
> to own finishing this, including removing the complex code that supported
> it. I have full confidence I can complete even labs this weekend.
>
> That said, I would appreciate committers watching on irc if github if you
> can, as I will need some +1s to finish this off. Unless all providers are
> moved off async, I can't remove the debty internal code.. so this is
> critical.
>
> Long story short.. hope to see some of you this weekend and let's finish
> this thing!
>
> -A
>