You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2019/09/21 00:28:24 UTC

[GitHub] [knox] moresandeep commented on a change in pull request #150: KNOX-2014 - Make sure ATLASSESSIONID cookie is set

moresandeep commented on a change in pull request #150: KNOX-2014 - Make sure ATLASSESSIONID cookie is set
URL: https://github.com/apache/knox/pull/150#discussion_r326838183
 
 

 ##########
 File path: gateway-provider-ha/src/main/java/org/apache/knox/gateway/ha/dispatch/DefaultHaDispatch.java
 ##########
 @@ -39,7 +39,7 @@
 /**
  * Default HA dispatch class that has a very basic failover mechanism
  */
-public class DefaultHaDispatch extends DefaultDispatch {
+public class DefaultHaDispatch extends ConfigurableDispatch {
 
 Review comment:
   Agreed, but the change does not affect the existing features it just adds the configurability. So, in theory there is really no change. Creating a separate dispatch, like I mentioned in the PR, would simply duplicate the code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services