You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/04/23 16:09:02 UTC
[GitHub] [echarts] xiaoyueguang opened a new pull request #14779: fix(heatmap): add option for align in heatmap
xiaoyueguang opened a new pull request #14779:
URL: https://github.com/apache/echarts/pull/14779
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [ ] bug fixing
- [x] new feature
- [ ] others
### What does this PR do?
add option called strictlyAligned, fix lines aligned in Heatmap.
### Fixed issues
[issues/14733](https://github.com/apache/echarts/issues/14733)
## Details
### Before: What was the problem?
Lines are not aligned in Heatmap
You can see this [demo](https://jsfiddle.net/mdgjno6w/)
### After: How is it fixed in this PR?
The error is caused by the conversion of the decimal point to an integer.
```ts
// src/chart/heatmap/HeatmapView.ts
rect = new graphic.Rect({
shape: {
x: Math.floor(Math.round(point[0]) - width / 2),
y: Math.floor(Math.round(point[1]) - height / 2),
width: Math.ceil(width),
height: Math.ceil(height)
},
style
});
```
I add an option to fix this issues, but this will cause performance issues.
So developers can look at the scene to determine whether to enable.
## Misc
<!-- ADD RELATED ISSUE ID WHEN APPLICABLE -->
- [x] The API has been changed (apache/echarts-doc#xxx).
- [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
### Related test cases or examples to use the new APIs
`test/heatmap-strictly-aligned.html`
NA.
## Others
### Merging options
- [x] Please squash the commits into a single one when merge.
### Other information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang commented on pull request #14779: fix(heatmap): add option for align in heatmap
Posted by GitBox <gi...@apache.org>.
pissang commented on pull request #14779:
URL: https://github.com/apache/echarts/pull/14779#issuecomment-826242031
I'm not sure if this configuration can fix the gap issue in the heatmap because it heavily depends on the resolution of end-user screen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang removed a comment on pull request #14779: fix(heatmap): add option for align in heatmap
Posted by GitBox <gi...@apache.org>.
pissang removed a comment on pull request #14779:
URL: https://github.com/apache/echarts/pull/14779#issuecomment-826242031
I'm not sure if this configuration can fix the gap issue in the heatmap because it heavily depends on the resolution of end-user screen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang commented on pull request #14779: fix(heatmap): add option for align in heatmap
Posted by GitBox <gi...@apache.org>.
pissang commented on pull request #14779:
URL: https://github.com/apache/echarts/pull/14779#issuecomment-826242031
I'm not sure if this configuration can fix the gap issue in the heatmap because it heavily depends on the resolution of end-user screen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang removed a comment on pull request #14779: fix(heatmap): add option for align in heatmap
Posted by GitBox <gi...@apache.org>.
pissang removed a comment on pull request #14779:
URL: https://github.com/apache/echarts/pull/14779#issuecomment-826242031
I'm not sure if this configuration can fix the gap issue in the heatmap because it heavily depends on the resolution of end-user screen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #14779: fix(heatmap): add option for align in heatmap
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #14779:
URL: https://github.com/apache/echarts/pull/14779#issuecomment-825761936
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
Document changes are required in this PR. Please also make a PR to [apache/echarts-doc](https://github.com/apache/echarts-doc) for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the `PR: awaiting doc` label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org