You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/01/17 17:44:35 UTC

[GitHub] TisonKun commented on a change in pull request #6917: [FLINK-10665] [tests] Remove legacy test YARNSessionFIFOITCase#testJavaAPI

TisonKun commented on a change in pull request #6917: [FLINK-10665] [tests] Remove legacy test YARNSessionFIFOITCase#testJavaAPI
URL: https://github.com/apache/flink/pull/6917#discussion_r248773430
 
 

 ##########
 File path: flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNSessionFIFOITCase.java
 ##########
 @@ -276,19 +280,21 @@ public void testfullAlloc() throws IOException {
 	 */
 	@Test
 	public void testJavaAPI() throws Exception {
 
 Review comment:
   Thanks for your investigation. I've checkout it and agree with you, adding a follow-up to address your comment.
   
   As a following consideration, we should properly test FLINK on YARN in the future. Current status is not quite robust and elegant IMO (ó﹏ò｡)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services