You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/15 07:35:53 UTC
[GitHub] [airflow] HaloKo4 opened a new issue #14232: upgrade checker missing rule
HaloKo4 opened a new issue #14232:
URL: https://github.com/apache/airflow/issues/14232
**What happened**:
The current upgrade-checker (1.2.0) doesn't have rule handle moving of classes / functions in the utils path.
Example:
from airflow.utils.db import create_session
changed to:
from airflow.utils.session import create_session
**What you expected to happen**:
provide notice on these changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Dr-Denzy commented on issue #14232: upgrade checker missing rule
Posted by GitBox <gi...@apache.org>.
Dr-Denzy commented on issue #14232:
URL: https://github.com/apache/airflow/issues/14232#issuecomment-779275999
@HaloKo4 This should be a `kind:feature` and not necessarily a bug.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal closed issue #14232: upgrade checker missing rule
Posted by GitBox <gi...@apache.org>.
eladkal closed issue #14232:
URL: https://github.com/apache/airflow/issues/14232
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #14232: upgrade checker missing rule
Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #14232:
URL: https://github.com/apache/airflow/issues/14232#issuecomment-787453725
@Dr-Denzy on 2nd thought, after reading carefully the issue again this task should not be done.
https://github.com/apache/airflow/blob/2fa3774608af9369135381c45529d3cf6f8c0e1a/airflow/utils/db.py#L38
isn't deprecated on 1.10.14
The function is deprecated only from >=2.0.0 so there is no action to take when upgrading from 1.10.14 to 2.0
We already decided not to suggest changes that will break dags on 1.10.x https://github.com/apache/airflow/pull/13012
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Dr-Denzy commented on issue #14232: upgrade checker missing rule
Posted by GitBox <gi...@apache.org>.
Dr-Denzy commented on issue #14232:
URL: https://github.com/apache/airflow/issues/14232#issuecomment-779271481
I will look into this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org