You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by inbar stolberg <no...@github.com> on 2014/10/09 18:18:25 UTC
[jclouds-labs-openstack] openstack glance added option copy from to
create image (#162)
You can merge this Pull Request by running:
git pull https://github.com/inbarsto/cloudband-jclouds-labs-openstack glanceCopyFrom2
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-labs-openstack/pull/162
-- Commit Summary --
* openstack glance added option copy from to create image
-- File Changes --
M openstack-glance/src/main/java/org/jclouds/openstack/glance/v1_0/options/CreateImageOptions.java (17)
-- Patch Links --
https://github.com/jclouds/jclouds-labs-openstack/pull/162.patch
https://github.com/jclouds/jclouds-labs-openstack/pull/162.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/162
Re: [jclouds-labs-openstack] openstack glance added option copy from
to create image (#162)
Posted by Andrew Phillips <no...@github.com>.
> @@ -39,6 +40,10 @@
> @Test(groups = "live", testName = "ImageApiLiveTest")
> public class ImageApiLiveTest extends BaseGlanceApiLiveTest {
>
> + private static final int TWO_MINUTES = 120;
> + private static final int FIVE_SECONDS = 5;
> + public static final String IMAGE_NAME = "jclouds-live-test";
@inbarsto Is it OK if we always try to use a fixed name here, e.g. does it always get cleaned up? Or would it be safer to create a unique image name?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/162/files#r18748221
Re: [jclouds-labs-openstack] openstack glance added option copy from
to create image (#162)
Posted by inbar stolberg <no...@github.com>.
fixed the test/s :grin:
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/162#issuecomment-58812856
Re: [jclouds-labs-openstack] openstack glance added option copy from
to create image (#162)
Posted by inbar stolberg <no...@github.com>.
having problems regarding checkstyle
@jdaggett any advice?
[istolber@dev-istolber:openstack-glance]$ mvn checkstyle:checkstyle
[INFO] Scanning for projects...
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building jclouds openstack-glance api 2.0.0-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO]
[INFO] --- maven-checkstyle-plugin:2.13:checkstyle (default-cli) @ openstack-glance ---
[INFO]
[WARNING] Unable to locate Source XRef to link to - DISABLED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 2.971s
[INFO] Finished at: Thu Oct 09 19:33:39 IDT 2014
[INFO] Final Memory: 22M/214M
[INFO] ------------------------------------------------------------------------
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/162#issuecomment-58537438
Re: [jclouds-labs-openstack] openstack glance added option copy from
to create image (#162)
Posted by inbar stolberg <no...@github.com>.
Good to go?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/162#issuecomment-58818196
Re: [jclouds-labs-openstack] openstack glance added option copy from
to create image (#162)
Posted by Andrew Phillips <no...@github.com>.
> i don't believe they are this PR related...
You're right - they're related to the ongoing 1.8.1 release (1.8.x is currently pointing to a not-yet-published 1.8.1 parent POM).
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/162#issuecomment-58817573
Re: [jclouds-labs-openstack] openstack glance added option copy from
to create image (#162)
Posted by inbar stolberg <no...@github.com>.
this is the fixed PR #152
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/162#issuecomment-58534976
Re: [jclouds-labs-openstack] openstack glance added option copy from
to create image (#162)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-openstack #1837](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1837/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/162#issuecomment-58569064
Re: [jclouds-labs-openstack] openstack glance added option copy from
to create image (#162)
Posted by inbar stolberg <no...@github.com>.
I am actually using this for the good part of a year now to upload images to openstack though third party image server or internal image server (instead of sending the payload through jclouds...)
regarding the test since we dont have a known public http server and openstacks that are open to it it will be kinda wierd to add a live test to it.
as for expected i can add it but the response should remain the same :/
any thoughts?
btw checkstyle fails at neutron...
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/162#issuecomment-58546416
Re: [jclouds-labs-openstack] openstack glance added option copy from
to create image (#162)
Posted by Andrew Phillips <no...@github.com>.
> But I'm not sure if that's also true on 1.8.x.
PS: Sorry, can't verify that right now as I'm in the middle of the 1.8.1 release ;-)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/162#issuecomment-58546071
Re: [jclouds-labs-openstack] openstack glance added option copy from
to create image (#162)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-openstack #1835](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1835/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/162#issuecomment-58536945
Re: [jclouds-labs-openstack] openstack glance added option copy from
to create image (#162)
Posted by inbar stolberg <no...@github.com>.
cloudbees having problems, i don't believe they are this PR related...
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/162#issuecomment-58813374
Re: [jclouds-labs-openstack] openstack glance added option copy from
to create image (#162)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-openstack-pull-requests #464](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/464/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/162#issuecomment-58812860
Re: [jclouds-labs-openstack] openstack glance added option copy from
to create image (#162)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-openstack-pull-requests #462](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/462/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/162#issuecomment-58536959
Re: [jclouds-labs-openstack] openstack glance added option copy from
to create image (#162)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-openstack-pull-requests #463](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/463/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/162#issuecomment-58568326
Re: [jclouds-labs-openstack] openstack glance added option copy from
to create image (#162)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-openstack #1842](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1842/) FAILURE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/162#issuecomment-58812823
Re: [jclouds-labs-openstack] openstack glance added option copy from
to create image (#162)
Posted by Andrew Phillips <no...@github.com>.
> Good to go?
Waiting for 1.8.1 (the 1.8.x branch is frozen right now). Just about to push a PR for master...
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/162#issuecomment-58819020
Re: [jclouds-labs-openstack] openstack glance added option copy from
to create image (#162)
Posted by Andrew Phillips <no...@github.com>.
> + public void testCreateImageCopyFromLocation() {
> + StringPayload imageData = new StringPayload("");
> + for (String region : api.getConfiguredZones()) {
> + ImageApi imageApi = api.getImageApiForZone(region);
> + ImageDetails details = imageApi.create("jclouds-live-test", imageData, diskFormat(DiskFormat.RAW), containerFormat(ContainerFormat.BARE), copyFrom("http://10.5.5.121/Installs/Templates/tiny/tinylinux-v2.qcow2"));
> + assertEquals(details.getName(), "jclouds-live-test");
> +
> + Image fromListing = imageApi.get(details.getId());
> +
> + assertEquals(fromListing.getId(), details.getId());
> + assertEquals(fromListing.getSize(), details.getSize());
> + assertEquals(fromListing.getContainerFormat(), details.getContainerFormat());
> + assertEquals(fromListing.getDiskFormat(), details.getDiskFormat());
> + assertEquals(fromListing.getSize(), details.getSize());
> +
> + assertTrue(imageApi.delete(details.getId()));
@inbarsto Related to the above comment: if one of the assertions _before_ this fails, the image may not be cleaned up. Is that correct? If so, add an `@AfterClass` or so to always try to clean the image up?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/162/files#r18748241
Re: [jclouds-labs-openstack] openstack glance added option copy from
to create image (#162)
Posted by Andrew Phillips <no...@github.com>.
Hi @inbarsto!
Thanks for this! I may be missing something, but do we need a test here? Or is this covered by some other test scenario? Also, out of curiosity: is this being added for completeness, or do you need this option for one of your apps?
Regarding Checkstyle: `checkstyle:check` _should_ be automatically run in the `verify` phase, i.e. if you run `mvn clean verify`. But I'm not sure if that's also true on 1.8.x.
You can see the Checkstyle output [here](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/462/violations/), if that helps?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/162#issuecomment-58545055
Re: [jclouds-labs-openstack] openstack glance added option copy from
to create image (#162)
Posted by inbar stolberg <no...@github.com>.
Seems like the is an unrelated test in neutron lbaas that fails ...
Good to go?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/162#issuecomment-58569431
Re: [jclouds-labs-openstack] openstack glance added option copy from
to create image (#162)
Posted by inbar stolberg <no...@github.com>.
added expect and live tests :)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/162#issuecomment-58567561
Re: [jclouds-labs-openstack] openstack glance added option copy from
to create image (#162)
Posted by Andrew Phillips <no...@github.com>.
Closed #162.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/162#event-183119804
Re: [jclouds-labs-openstack] openstack glance added option copy from
to create image (#162)
Posted by Andrew Phillips <no...@github.com>.
Committed to [1.8.x](https://git-wip-us.apache.org/repos/asf?p=jclouds-labs-openstack.git;a=commit;h=c82fbd1698b085ba4cfe5a4e3af9cc960b12cd74).
Thanks, @inbarsto!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/162#issuecomment-60346385