You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "slawekjaranowski (via GitHub)" <gi...@apache.org> on 2023/03/07 10:21:43 UTC
[GitHub] [maven-surefire] slawekjaranowski opened a new pull request, #617: [SUREFIRE-2154] Get rid of localRepository from surefire mojo parameter
slawekjaranowski opened a new pull request, #617:
URL: https://github.com/apache/maven-surefire/pull/617
- not use org.apache.maven.artifact.repository.ArtifactRepository
- use resolver API
---
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean install` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean install`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] olamy commented on pull request #617: [SUREFIRE-2154] Get rid of localRepository from surefire mojo parameter
Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy commented on PR #617:
URL: https://github.com/apache/maven-surefire/pull/617#issuecomment-1458889130
the change is larger than what the description says...
especially dependencies resolves in a different way so jira PR title needs to be updated.
such change can definitely breaks things so it must be correctly described as part of the release notes and corresponding jira/PRs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slachiewicz commented on a diff in pull request #617: [SUREFIRE-2154] Get rid of localRepository from surefire mojo parameter, use Resolver API
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on code in PR #617:
URL: https://github.com/apache/maven-surefire/pull/617#discussion_r1129237191
##########
maven-surefire-common/pom.xml:
##########
@@ -52,6 +52,12 @@
<artifactId>maven-core</artifactId>
<scope>provided</scope>
</dependency>
+ <dependency>
+ <groupId>org.eclipse.aether</groupId>
+ <artifactId>aether-util</artifactId>
+ <!-- tha same version as i Maven 3.2.5 -->
Review Comment:
i -> in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] cstamas commented on pull request #617: [SUREFIRE-2154] Get rid of localRepository from surefire mojo parameter, use Resolver API
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #617:
URL: https://github.com/apache/maven-surefire/pull/617#issuecomment-1460572120
Another example of insane overhead of all legacy stuff: 800 lines less! Great job @slawekjaranowski
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] olamy commented on a diff in pull request #617: [SUREFIRE-2154] Get rid of localRepository from surefire mojo parameter, use Resolver API
Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy commented on code in PR #617:
URL: https://github.com/apache/maven-surefire/pull/617#discussion_r1129203092
##########
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireDependencyResolver.java:
##########
@@ -59,7 +62,10 @@
* @author Stephen Connolly
* @author Kristian Rosenvold
*/
-final class SurefireDependencyResolver {
+@Named
+@Singleton
+public class SurefireDependencyResolver {
Review Comment:
ditto this is turning this class into a public API.
Do we really need to publish and support another way of resolving dependencies?
why not simply having some similar private constructor and avoid exposing something else we will have to support.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski merged pull request #617: [SUREFIRE-2154] Get rid of localRepository from surefire mojo parameter, use Resolver API
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski merged PR #617:
URL: https://github.com/apache/maven-surefire/pull/617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on pull request #617: [SUREFIRE-2154] Get rid of localRepository from surefire mojo parameter, use Resolver API
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #617:
URL: https://github.com/apache/maven-surefire/pull/617#issuecomment-1459669226
@olamy jira issue updated - any remarks to change?
As we see all ITs pass without changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] olamy commented on a diff in pull request #617: [SUREFIRE-2154] Get rid of localRepository from surefire mojo parameter, use Resolver API
Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy commented on code in PR #617:
URL: https://github.com/apache/maven-surefire/pull/617#discussion_r1130019507
##########
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireDependencyResolver.java:
##########
@@ -59,7 +62,10 @@
* @author Stephen Connolly
* @author Kristian Rosenvold
*/
-final class SurefireDependencyResolver {
+@Named
+@Singleton
+public class SurefireDependencyResolver {
Review Comment:
Thanks!
Not sure why "the best way"? do you plan to introduce alternate implementations?
so no need to introduce interface for a package private class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on a diff in pull request #617: [SUREFIRE-2154] Get rid of localRepository from surefire mojo parameter, use Resolver API
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #617:
URL: https://github.com/apache/maven-surefire/pull/617#discussion_r1129299228
##########
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireDependencyResolver.java:
##########
@@ -59,7 +62,10 @@
* @author Stephen Connolly
* @author Kristian Rosenvold
*/
-final class SurefireDependencyResolver {
+@Named
+@Singleton
+public class SurefireDependencyResolver {
Review Comment:
I changed to package private.
The best way will be introduce interface for this component and move implementation to another place
but this class contains a static methods which is used in AbstractSurefireMojo.
So usage is mixed, I would not extends this PR too more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on a diff in pull request #617: [SUREFIRE-2154] Get rid of localRepository from surefire mojo parameter, use Resolver API
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #617:
URL: https://github.com/apache/maven-surefire/pull/617#discussion_r1129299455
##########
maven-surefire-common/pom.xml:
##########
@@ -52,6 +52,12 @@
<artifactId>maven-core</artifactId>
<scope>provided</scope>
</dependency>
+ <dependency>
+ <groupId>org.eclipse.aether</groupId>
+ <artifactId>aether-util</artifactId>
+ <!-- tha same version as i Maven 3.2.5 -->
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org