You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Tyler Hobbs (JIRA)" <ji...@apache.org> on 2013/08/09 21:43:47 UTC
[jira] [Commented] (CASSANDRA-5859) Don't return internal
StreamState objects from streaming mbeans
[ https://issues.apache.org/jira/browse/CASSANDRA-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13735192#comment-13735192 ]
Tyler Hobbs commented on CASSANDRA-5859:
----------------------------------------
In {{ProgressInfoCompositeData}}, the direction is being reported as a single byte, 0 or 1, which can't be interpreted without the internal enum. Just using a string "in" or "out" or a boolean with name "outbound" would be fine.
There are several alignment issues around one-arg-per-line lists in all of the new streaming.management classes. For example:
{noformat}
COMPOSITE_TYPE = new CompositeType(ProgressInfo.class.getName(),
"ProgressInfo",
ITEM_NAMES,
ITEM_DESCS,
ITEM_TYPES);
{noformat}
Other than those two minor issues, +1.
> Don't return internal StreamState objects from streaming mbeans
> ---------------------------------------------------------------
>
> Key: CASSANDRA-5859
> URL: https://issues.apache.org/jira/browse/CASSANDRA-5859
> Project: Cassandra
> Issue Type: Bug
> Reporter: Nick Bailey
> Assignee: Yuki Morishita
> Labels: streaming
> Fix For: 2.0
>
> Attachments: 5859.txt
>
>
> The stream manager mbean returns StreamState objects. We want to avoid returning internal C* objects over jmx. We should switch to a map or something similar that can represent streaming state.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira