You are viewing a plain text version of this content. The canonical link for it is here.
Posted to soap-dev@xml.apache.org by sn...@apache.org on 2002/10/04 14:58:26 UTC

cvs commit: xml-soap/java/src/org/apache/soap Envelope.java

snichol     2002/10/04 05:58:26

  Modified:    java/src/org/apache/soap Envelope.java
  Log:
  Submitted by: Pavel Ausianik <Pa...@epam.com>
  Reviewed by: Scott Nichol
  Refer to: http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12539
  
  class org.apache.soap.Envelope causes unnecessary memory allocations
  
  Revision  Changes    Path
  1.9       +10 -9     xml-soap/java/src/org/apache/soap/Envelope.java
  
  Index: Envelope.java
  ===================================================================
  RCS file: /home/cvs/xml-soap/java/src/org/apache/soap/Envelope.java,v
  retrieving revision 1.8
  retrieving revision 1.9
  diff -u -r1.8 -r1.9
  --- Envelope.java	30 Aug 2002 19:08:07 -0000	1.8
  +++ Envelope.java	4 Oct 2002 12:58:26 -0000	1.9
  @@ -79,19 +79,21 @@
     private Vector           envelopeEntries = null;
     private AttributeHandler attrHandler     = new AttributeHandler();
   
  +  private static final QName N_SOAP_ENV = new QName(Constants.NS_URI_XMLNS,  Constants.NS_PRE_SOAP_ENV);
  +  private static final QName N_SCHEMA_XSI = new QName(Constants.NS_URI_XMLNS,  Constants.NS_PRE_SCHEMA_XSI);
  +  private static final QName N_SCHEMA_XSD = new QName(Constants.NS_URI_XMLNS,  Constants.NS_PRE_SCHEMA_XSD);
  +  private static final QName N_ENCOD_STYLE = new QName(Constants.NS_URI_SOAP_ENV, Constants.ATTR_ENCODING_STYLE);
  +
     public Envelope()
     {
       // Declare the "SOAP-ENV" namespace.
  -    declareNamespace(Constants.NS_PRE_SOAP_ENV,
  -                     Constants.NS_URI_SOAP_ENV);
  +    setAttribute(N_SOAP_ENV, Constants.NS_URI_SOAP_ENV);
   
       // Declare the "xsi" namespace.
  -    declareNamespace(Constants.NS_PRE_SCHEMA_XSI,
  -                     Constants.NS_URI_CURRENT_SCHEMA_XSI);
  +    setAttribute(N_SCHEMA_XSI, Constants.NS_PRE_SCHEMA_XSI);
   
       // Declare the "xsd" namespace.
  -    declareNamespace(Constants.NS_PRE_SCHEMA_XSD,
  -                     Constants.NS_URI_CURRENT_SCHEMA_XSD);
  +    setAttribute(N_SCHEMA_XSD, Constants.NS_URI_CURRENT_SCHEMA_XSD);
     }
   
     public void setAttribute(QName attrQName, String value)
  @@ -166,8 +168,7 @@
       Header header          = getHeader();
       Body   body            = getBody();
       Vector envelopeEntries = getEnvelopeEntries();
  -    String declEncStyle    = getAttribute(new QName(
  -      Constants.NS_URI_SOAP_ENV, Constants.ATTR_ENCODING_STYLE));
  +    String declEncStyle    = getAttribute(N_ENCOD_STYLE);
   
       // Determine the prefix associated with the NS_URI_SOAP_ENV namespace URI.
       String soapEnvNSPrefix = attrHandler.getUniquePrefixFromURI(
  @@ -214,7 +215,7 @@
         }
       }
   
  -    sink.write("</" + soapEnvNSPrefix + ':' + Constants.ELEM_ENVELOPE + 
  +    sink.write("</" + soapEnvNSPrefix + ':' + Constants.ELEM_ENVELOPE +
                  '>' + StringUtils.lineSeparator);
     }
   
  
  
  

--
To unsubscribe, e-mail:   <ma...@xml.apache.org>
For additional commands, e-mail: <ma...@xml.apache.org>