You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2026/04/30 14:04:35 UTC

Re: [PR] fix(translation): loading translations before app [superset]

rusackas commented on PR #35640:
URL: https://github.com/apache/superset/pull/35640#issuecomment-4353118397

   @jakubhruby thanks for working on this — wanted to flag a couple of things before we can move forward:
   
   1. **Regression report from @tahvane1** ([comment](https://github.com/apache/superset/pull/35640#issuecomment-3679403450)): with this fix applied, `ENABLE_DASHBOARD_SCREENSHOT_ENDPOINTS` and `ENABLE_DASHBOARD_DOWNLOAD_WEBDRIVER_SCREENSHOT` stop working — sounds like the worker is unable to connect/authenticate. My guess is that the headless screenshot path is now stuck waiting on `i18nLoadJob` because `bootstrapData.common.locale` isn't populated the same way in that context. Could you take a look and either reproduce or rule it out?
   
   2. **Conflicts with master** — the branch needs a rebase before it can be merged.
   
   Once those are addressed I'll take another look. Appreciate the patch — the screenshots in the description make the bug very clear.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org