You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/15 06:38:40 UTC

[GitHub] [incubator-nuttx-apps] Donny9 opened a new pull request #384: Fix multi MAINSRC match suffix in single Makefile

Donny9 opened a new pull request #384:
URL: https://github.com/apache/incubator-nuttx-apps/pull/384


   ## Summary
   Fix multi MAINSRC match suffix in single Makefile 
   
   ## Impact
   We can compile multi program in single makefile with different suffix file in MAINSRC.
   eg: MAINSRC = xxx1.c
         PROGNAME = xxx1
         MAINSRC += xxx2.cpp
         RROGNAME += xxx2
   
   ## Testing
   Built locally
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #384: Fix multi MAINSRC match suffix in single Makefile

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #384:
URL: https://github.com/apache/incubator-nuttx-apps/pull/384#issuecomment-695236736


   Ok, let's go ahead.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] Donny9 edited a comment on pull request #384: Fix multi MAINSRC match suffix in single Makefile

Posted by GitBox <gi...@apache.org>.
Donny9 edited a comment on pull request #384:
URL: https://github.com/apache/incubator-nuttx-apps/pull/384#issuecomment-692734919


   > This feels conceptually wrong, why would need two main files? There should be only a single entry function, regardless of C vs C++ (which is currently supported). If there are two "main" this are two separate applications. An app with two mains does not exist in other OSs.
   
   Hello @v01d ,you can see following makefile about zmodem, it uses double main file.
   https://github.com/apache/incubator-nuttx-apps/blob/master/system/zmodem/Makefile


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] v01d commented on pull request #384: Fix multi MAINSRC match suffix in single Makefile

Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #384:
URL: https://github.com/apache/incubator-nuttx-apps/pull/384#issuecomment-692738484


   I'm not sure I follow how that works or why is designed that way.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] v01d commented on pull request #384: Fix multi MAINSRC match suffix in single Makefile

Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #384:
URL: https://github.com/apache/incubator-nuttx-apps/pull/384#issuecomment-692722967


   This feels conceptually wrong, why would need two main files? There should be only a single entry function, regardless of C vs C++ (which is currently supported). If there are two "main" this are two separate applications. An app with two mains does not exist in other OSs. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] Donny9 edited a comment on pull request #384: Fix multi MAINSRC match suffix in single Makefile

Posted by GitBox <gi...@apache.org>.
Donny9 edited a comment on pull request #384:
URL: https://github.com/apache/incubator-nuttx-apps/pull/384#issuecomment-692734919


   > This feels conceptually wrong, why would need two main files? There should be only a single entry function, regardless of C vs C++ (which is currently supported). If there are two "main" this are two separate applications. An app with two mains does not exist in other OSs.
   
   Hello @v01d ,you can see following makefile about zmodem, it use double main file.
   https://github.com/apache/incubator-nuttx-apps/blob/master/system/zmodem/Makefile


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #384: Fix multi MAINSRC match suffix in single Makefile

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #384:
URL: https://github.com/apache/incubator-nuttx-apps/pull/384


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] Donny9 commented on pull request #384: Fix multi MAINSRC match suffix in single Makefile

Posted by GitBox <gi...@apache.org>.
Donny9 commented on pull request #384:
URL: https://github.com/apache/incubator-nuttx-apps/pull/384#issuecomment-692734919


   > This feels conceptually wrong, why would need two main files? There should be only a single entry function, regardless of C vs C++ (which is currently supported). If there are two "main" this are two separate applications. An app with two mains does not exist in other OSs.
   
   Hello @v01d ,you can see following makefile about zmode, it use double main file.
   https://github.com/apache/incubator-nuttx-apps/blob/master/system/zmodem/Makefile


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] v01d commented on pull request #384: Fix multi MAINSRC match suffix in single Makefile

Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #384:
URL: https://github.com/apache/incubator-nuttx-apps/pull/384#issuecomment-695215384


   Yes, I approved, you can merge if you agree as well.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #384: Fix multi MAINSRC match suffix in single Makefile

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #384:
URL: https://github.com/apache/incubator-nuttx-apps/pull/384#issuecomment-695156155


   @v01d should we merge this PR? We can create a new issue to track the problem of application structure.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] v01d commented on pull request #384: Fix multi MAINSRC match suffix in single Makefile

Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #384:
URL: https://github.com/apache/incubator-nuttx-apps/pull/384#issuecomment-692740372


   Ah, I see there are two PROGNAME. Well, I can't say I like the idea. In any other OS you would have to different applications built separately sharing common code via a library. This is actually possible in NuttX, it only takes more work. Anyway, I understand you are simple allowing different languages for each main.
   I can approve the change, even if I don't really like the idea (which is independent of this PR)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org