[GitHub] [nifi] szaboferee opened a new pull request #3379: NIFI-4735: ParseEVTX only outputs one event per chunk

[GitBox <gi...@apache.org>]

szaboferee opened a new pull request #3379: NIFI-4735: ParseEVTX only outputs one event per chunk
URL: https://github.com/apache/nifi/pull/3379
 
 
   This change is based on https://github.com/apache/nifi/pull/2489
   
   I have reproduced the issue with some additional test cases and test files then applied the original fix.
   
   commit message from the original change:
   Updated the EVTX FileHeader class to correctly check if there are more chunks in the file. Previously this would not process the last chunk.
   
   Updated the EVTX ChunkHeader class to correctly check if there are additional records in the chunk. Previously this would only process the first record of each chunk. It was using the fileLastRecordNumber where it should have been using the logLastRecordNumber value.
   
   Updated the EVTX unit tests to have the correct expected number of events and use the logLastRecordNumber.
   
   Thank you for submitting a contribution to Apache NiFi.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
        in the commit message?
   
   - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
   
   - [x] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
   - [x] Have you written or updated unit tests to verify your changes?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
   - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
   - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
   - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services