You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@celix.apache.org by GitBox <gi...@apache.org> on 2020/11/30 13:35:29 UTC
[GitHub] [celix] PengZheng opened a new issue #299: Missing function call
PengZheng opened a new issue #299:
URL: https://github.com/apache/celix/issues/299
https://github.com/apache/celix/blob/master/libs/framework/src/framework.c#L770-L771
```C
status = CELIX_BUNDLE_EXCEPTION;
status = CELIX_DO_IF(status, bundleArchive_closeAndDelete(archive));
```
`bundleArchive_closeAndDelete` will never been called.
Is it intentional or is it a bug?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] Oipo commented on issue #299: Missing function call
Posted by GitBox <gi...@apache.org>.
Oipo commented on issue #299:
URL: https://github.com/apache/celix/issues/299#issuecomment-737818752
Looks like a bug to me. But the solution isn't clear to me yet. Closing/deleting the archive which has been passed to `fw_installBundle2` sounds like a possible unwanted side-effect. [Line 488](https://github.com/apache/celix/blob/master/libs/framework/src/framework.c#L488) for example, passes an archive from an array list. I'd imagine that if the returned status of `fw_installBundle2` is `CELIX_BUNDLE_EXCEPTION`, the entry in the array list should be removed as well. And that's just one of the uses of `fw_installBundle2`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org