You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by lamber-ken <gi...@git.apache.org> on 2018/06/27 08:14:00 UTC
[GitHub] flink pull request #6212: [FLINK-9666] short-circuit logic should be used in...
GitHub user lamber-ken opened a pull request:
https://github.com/apache/flink/pull/6212
[FLINK-9666] short-circuit logic should be used in boolean contexts
## What is the purpose of the change
- short-circuit logic should be used in boolean contexts, | -> ||, & -> &&
## Brief change log
- short-circuit logic should be used in boolean contexts, | -> ||, & -> &&
## Verifying this change
- short-circuit logic should be used in boolean contexts, | -> ||, & -> &&
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (JavaDocs)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lamber-ken/flink lamber-ken-fix-FLINK-9666
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6212.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6212
----
commit 1a8e1f6193823e70b1dc6abc1146299042c25c7d
Author: lamber-ken <!...@...>
Date: 2018-06-20T04:26:10Z
add prometheus pushgateway reporter
commit 96a4bf7cd294bdfa079f3aae47114bbb013f52ac
Author: lamber-ken <!...@...>
Date: 2018-06-27T07:57:59Z
short-circuit logic should be used in boolean contexts
commit 85e962e252bea2959419e0de4fdeaa474ef2b506
Author: lamber-ken <!...@...>
Date: 2018-06-27T08:10:07Z
remove prometheus pushgateway
----
---
[GitHub] flink issue #6212: [FLINK-9666] short-circuit logic should be used in boolea...
Posted by lamber-ken <gi...@git.apache.org>.
Github user lamber-ken commented on the issue:
https://github.com/apache/flink/pull/6212
@zentol, ok
---
[GitHub] flink issue #6212: [FLINK-9666] short-circuit logic should be used in boolea...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/6212
Not sure where this comes from. But I've merged your commit into the master. See da37daa8ba.
---
[GitHub] flink issue #6212: [FLINK-9666] short-circuit logic should be used in boolea...
Posted by lamber-ken <gi...@git.apache.org>.
Github user lamber-ken commented on the issue:
https://github.com/apache/flink/pull/6212
maybe it's a bug
---
[GitHub] flink issue #6212: [FLINK-9666] short-circuit logic should be used in boolea...
Posted by lamber-ken <gi...@git.apache.org>.
Github user lamber-ken commented on the issue:
https://github.com/apache/flink/pull/6212
hi, @tillrohrmann , what does this mean?
I don't understand, need I delete the branch?
---
[GitHub] flink issue #6212: [FLINK-9666] short-circuit logic should be used in boolea...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6212
@lamber-ken This happened because @tillrohrmann modified the commit message to close the PR, which modified the commit hash.
As such, from GitHubs perspective, the PR was closed without the contained commit (as identified be the hash) being merged.
---
[GitHub] flink issue #6212: [FLINK-9666] short-circuit logic should be used in boolea...
Posted by lamber-ken <gi...@git.apache.org>.
Github user lamber-ken commented on the issue:
https://github.com/apache/flink/pull/6212
hi, @StephanEwen, cc, thx
---
[GitHub] flink issue #6212: [FLINK-9666] short-circuit logic should be used in boolea...
Posted by lamber-ken <gi...@git.apache.org>.
Github user lamber-ken commented on the issue:
https://github.com/apache/flink/pull/6212
hi, @tillrohrmann, if you don't know, I'll ignore it. it's no problem, :smiley:
This information is always displayed at the bottom of the page. here's it.
---
[GitHub] flink issue #6212: [FLINK-9666] short-circuit logic should be used in boolea...
Posted by lamber-ken <gi...@git.apache.org>.
Github user lamber-ken commented on the issue:
https://github.com/apache/flink/pull/6212
hi, @StephanEwen, @tillrohrmann cc.
---