You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by "Adam Heath (JIRA)" <ji...@apache.org> on 2007/05/14 16:48:16 UTC

[jira] Created: (VFS-151) Allow files to return a custom FileContentInfo

Allow files to return a custom FileContentInfo
----------------------------------------------

                 Key: VFS-151
                 URL: https://issues.apache.org/jira/browse/VFS-151
             Project: Commons VFS
          Issue Type: Improvement
    Affects Versions: 1.1
            Reporter: Adam Heath
            Priority: Minor


See attached patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Commented: (VFS-151) Allow files to return a custom FileContentInfo

Posted by "Mario Ivankovits (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/VFS-151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495728 ] 

Mario Ivankovits commented on VFS-151:
--------------------------------------

btw, the magic file stuff has not been implemented yet

> Allow files to return a custom FileContentInfo
> ----------------------------------------------
>
>                 Key: VFS-151
>                 URL: https://issues.apache.org/jira/browse/VFS-151
>             Project: Commons VFS
>          Issue Type: Improvement
>    Affects Versions: 1.1
>            Reporter: Adam Heath
>            Priority: Minor
>         Attachments: feature_FileContentInfo-subclass-overriding.patch
>
>
> See attached patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Updated: (VFS-151) Allow files to return a custom FileContentInfo

Posted by "Adam Heath (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/VFS-151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adam Heath updated VFS-151:
---------------------------

    Attachment: feature_FileContentInfo-subclass-overriding.patch

Against svn 501759.

> Allow files to return a custom FileContentInfo
> ----------------------------------------------
>
>                 Key: VFS-151
>                 URL: https://issues.apache.org/jira/browse/VFS-151
>             Project: Commons VFS
>          Issue Type: Improvement
>    Affects Versions: 1.1
>            Reporter: Adam Heath
>            Priority: Minor
>         Attachments: feature_FileContentInfo-subclass-overriding.patch
>
>
> See attached patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Resolved: (VFS-151) Allow files to return a custom FileContentInfo

Posted by "Mario Ivankovits (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/VFS-151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mario Ivankovits resolved VFS-151.
----------------------------------

    Resolution: Won't Fix

The FileContentInfo is not meant to be in the responsibility of the FileObject. Like the "file" command in unix the factory should try to determine the best FileContentInfo depending on the real FileContent by looking up the first few bytes and visiting a magic file.

Though, if the FileObject would like to have its own FileContentInfo it could override AbstractFileObject.getFileContentInfoFactory

> Allow files to return a custom FileContentInfo
> ----------------------------------------------
>
>                 Key: VFS-151
>                 URL: https://issues.apache.org/jira/browse/VFS-151
>             Project: Commons VFS
>          Issue Type: Improvement
>    Affects Versions: 1.1
>            Reporter: Adam Heath
>            Priority: Minor
>         Attachments: feature_FileContentInfo-subclass-overriding.patch
>
>
> See attached patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Commented: (VFS-151) Allow files to return a custom FileContentInfo

Posted by "Adam Heath (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/VFS-151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495738 ] 

Adam Heath commented on VFS-151:
--------------------------------

I have a FlatFileSystem.  This stores attributes for file 'foo' as 'foo@/attr-name'.  I make use of 2 attributes, for FileContentInfo support, 'content-type' and 'content-encoding'.  Implementing a factory, just this, seemed a waste; this actually seemed easier to do.

However, I do see how this could be done, using the factory.  I'll rewrite my code.

> Allow files to return a custom FileContentInfo
> ----------------------------------------------
>
>                 Key: VFS-151
>                 URL: https://issues.apache.org/jira/browse/VFS-151
>             Project: Commons VFS
>          Issue Type: Improvement
>    Affects Versions: 1.1
>            Reporter: Adam Heath
>            Priority: Minor
>         Attachments: feature_FileContentInfo-subclass-overriding.patch
>
>
> See attached patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org