[GitHub] [tvm] wrongtest-intellif opened a new pull request, #15292: [RPC] Fix socket bind errno on corner case

["wrongtest-intellif (via GitHub)" <gi...@apache.org>]

wrongtest-intellif opened a new pull request, #15292:
URL: https://github.com/apache/tvm/pull/15292

   Because `LOG(WARNING)` may invoke system calls, the errno of socket bind failure is overwrite, which make `TryBindPort` exit without any more trials.
   
   Here is an example from strace, the errno check should be put just after `bind` return.
   ```
   bind(3, {sa_family=AF_INET, sin_port=htons(9200), sin_addr=inet_addr("192.168.35.133")}, 16) = -1 EADDRINUSE (Address already in use)
   openat(AT_FDCWD, "/etc/localtime", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tvm-bot commented on pull request #15292: [RPC] Fix socket bind errno on corner case

["tvm-bot (via GitHub)" <gi...@apache.org>]

tvm-bot commented on PR #15292:
URL: https://github.com/apache/tvm/pull/15292#issuecomment-1630554857

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * No users to tag found in teams: `rpc` <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] Hzfengsy merged pull request #15292: [RPC] Fix socket bind errno on corner case

["Hzfengsy (via GitHub)" <gi...@apache.org>]

Hzfengsy merged PR #15292:
URL: https://github.com/apache/tvm/pull/15292


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org