You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Avinash sridharan <av...@mesosphere.io> on 2016/12/14 00:32:35 UTC
Review Request 54719: Added support for deleting CNI network from
`network/cni` isolator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54719/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Qian Zhang.
Bugs: MESOS-6567
https://issues.apache.org/jira/browse/MESOS-6567
Repository: mesos
Description
-------
During `prepare` or `isolate` if the `network/cni` isolator sees an
error while reading the CNI network configuration it goes ahead and
deletes the CNI network from the cache. This allows operators to
dynamically delete CNI network configuration without the need for an
agent restart.
Diffs
-----
src/slave/containerizer/mesos/isolators/network/cni/cni.cpp ddb4d33e9ecd0ffd118e8e68cb7ec90346b08049
Diff: https://reviews.apache.org/r/54719/diff/
Testing
-------
make check
Manual testing with removing CNI configuration while the agent was up, and verifying that the CNI network got deleted without the need for an agent restart.
Thanks,
Avinash sridharan
Re: Review Request 54719: Added support for deleting CNI network from
`network/cni` isolator.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54719/#review159124
-----------------------------------------------------------
Patch looks great!
Reviews applied: [54716, 54717, 54718, 54719]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 14, 2016, 12:32 a.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54719/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2016, 12:32 a.m.)
>
>
> Review request for mesos, Jie Yu and Qian Zhang.
>
>
> Bugs: MESOS-6567
> https://issues.apache.org/jira/browse/MESOS-6567
>
>
> Repository: mesos
>
>
> Description
> -------
>
> During `prepare` or `isolate` if the `network/cni` isolator sees an
> error while reading the CNI network configuration it goes ahead and
> deletes the CNI network from the cache. This allows operators to
> dynamically delete CNI network configuration without the need for an
> agent restart.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/network/cni/cni.cpp ddb4d33e9ecd0ffd118e8e68cb7ec90346b08049
>
> Diff: https://reviews.apache.org/r/54719/diff/
>
>
> Testing
> -------
>
> make check
>
> Manual testing with removing CNI configuration while the agent was up, and verifying that the CNI network got deleted without the need for an agent restart.
>
>
> Thanks,
>
> Avinash sridharan
>
>