[GitHub] [druid] zachjsh commented on a diff in pull request #14003: Allow for Input source security in native task layer

["zachjsh (via GitHub)" <gi...@apache.org>]

zachjsh commented on code in PR #14003:
URL: https://github.com/apache/druid/pull/14003#discussion_r1157512300


##########
extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/KafkaIndexTask.java:
##########
@@ -132,6 +136,20 @@ public String getType()
     return TYPE;
   }
 
+  @JsonIgnore
+  @Nullable
+  @Override
+  public Set<String> getInputSourceTypes()
+  {
+    return Collections.singleton("kafka");

Review Comment:
   added



##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/AppenderatorDriverRealtimeIndexTask.java:
##########
@@ -213,6 +215,20 @@ public String getType()
     return "index_realtime_appenderator";
   }
 
+  @JsonIgnore
+  @Nullable
+  @Override
+  public Set<String> getInputSourceTypes()
+  {
+    return null;

Review Comment:
   good point, changed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org