You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Brahma Reddy Battula (JIRA)" <ji...@apache.org> on 2015/02/18 15:39:11 UTC

[jira] [Commented] (HDFS-7808) Unused code in DFSHAAdmin.java

    [ https://issues.apache.org/jira/browse/HDFS-7808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14325950#comment-14325950 ] 

Brahma Reddy Battula commented on HDFS-7808:
--------------------------------------------

Nice Catch...It can be removed...

> Unused code in DFSHAAdmin.java
> ------------------------------
>
>                 Key: HDFS-7808
>                 URL: https://issues.apache.org/jira/browse/HDFS-7808
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Arshad Mohammad
>            Assignee: Arshad Mohammad
>            Priority: Minor
>
> After HDFS-7324 fix following piece of code become unused. It should be removed.
> {code}
>     int i = 0;
>     String cmd = argv[i++];
>     if ("-ns".equals(cmd)) {
>       if (i == argv.length) {
>         errOut.println("Missing nameservice ID");
>         printUsage(errOut);
>         return -1;
>       }
>       nameserviceId = argv[i++];
>       if (i >= argv.length) {
>         errOut.println("Missing command");
>         printUsage(errOut);
>         return -1;
>       }
>       argv = Arrays.copyOfRange(argv, i, argv.length);
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)