[GitHub] [drill] paul-rogers commented on issue #2000: DRILL-7607: Support dynamic credit based flow control

[GitBox <gi...@apache.org>]

paul-rogers commented on issue #2000: DRILL-7607: Support dynamic credit based flow control
URL: https://github.com/apache/drill/pull/2000#issuecomment-597239145
 
 
   Looks good, +1.
   
   Seems to me that two things need to happen after this PR. First, is to find a way to run a stress/performance test to ensure that the potential extra memory usage is not an issue. Second is to, at some point, continue with our resource management efforts and to 1) allocate memory to the receivers they can use as their buffer pool, and 2) standardize batch size so the receiver knows roughly the sizes to expect. This work is beyond the scope of this PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services