You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@answer.apache.org by "light-white (via GitHub)" <gi...@apache.org> on 2025/08/29 09:49:40 UTC

[PR] fix state to random code [answer-plugins]

light-white opened a new pull request, #297:
URL: https://github.com/apache/answer-plugins/pull/297

   fix state to random code


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix state to random code [answer-plugins]

Posted by "LinkinStars (via GitHub)" <gi...@apache.org>.
LinkinStars merged PR #297:
URL: https://github.com/apache/answer-plugins/pull/297


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix state to random code [answer-plugins]

Posted by "light-white (via GitHub)" <gi...@apache.org>.
light-white commented on code in PR #297:
URL: https://github.com/apache/answer-plugins/pull/297#discussion_r2313458909


##########
connector-basic/basic.go:
##########
@@ -117,7 +127,8 @@ func (g *Connector) ConnectorSender(ctx *plugin.GinContext, receiverURL string)
 		RedirectURL: receiverURL,
 		Scopes:      strings.Split(g.Config.Scope, ","),
 	}
-	return oauth2Config.AuthCodeURL("state")
+	state := state := randomString(24)

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix state to random code [answer-plugins]

Posted by "LinkinStars (via GitHub)" <gi...@apache.org>.
LinkinStars commented on code in PR #297:
URL: https://github.com/apache/answer-plugins/pull/297#discussion_r2312769587


##########
connector-basic/basic.go:
##########
@@ -117,7 +127,8 @@ func (g *Connector) ConnectorSender(ctx *plugin.GinContext, receiverURL string)
 		RedirectURL: receiverURL,
 		Scopes:      strings.Split(g.Config.Scope, ","),
 	}
-	return oauth2Config.AuthCodeURL("state")
+	state := state := randomString(24)

Review Comment:
   No need to assign values twice.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org