You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "SteveYurongSu (via GitHub)" <gi...@apache.org> on 2024/08/20 11:03:10 UTC
[PR] Pipe: Convert tsfile to tablets on data sync receiver when data type / aligned type mismatch detected [iotdb]
SteveYurongSu opened a new pull request, #13239:
URL: https://github.com/apache/iotdb/pull/13239
As title.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Pipe: Convert tsfile to tablets on data sync receiver when data type / aligned type mismatch detected [iotdb]
Posted by "SteveYurongSu (via GitHub)" <gi...@apache.org>.
SteveYurongSu commented on PR #13239:
URL: https://github.com/apache/iotdb/pull/13239#issuecomment-2298583126
@luoluoyuyu PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Pipe: Convert tsfile to tablets on data sync receiver when data type / aligned type mismatch detected [iotdb]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #13239:
URL: https://github.com/apache/iotdb/pull/13239#issuecomment-2298910751
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=13239) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=13239&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=13239&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=13239&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=13239&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=13239&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=13239)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Pipe: Convert tsfile to tablets on data sync receiver when data type / aligned type mismatch detected [iotdb]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #13239:
URL: https://github.com/apache/iotdb/pull/13239#issuecomment-2299024840
## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/13239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `0%` with `36 lines` in your changes missing coverage. Please review.
> Project coverage is 41.23%. Comparing base [(`e186184`)](https://app.codecov.io/gh/apache/iotdb/commit/e1861849160907caa3fa47dc8c5d7405cc51d286?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`4ee3723`)](https://app.codecov.io/gh/apache/iotdb/commit/4ee3723ecdd01200560dd1cc0cf8c8f2b34285c7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 2 commits behind head on master.
| [Files](https://app.codecov.io/gh/apache/iotdb/pull/13239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../PipeStatementDataTypeConvertExecutionVisitor.java](https://app.codecov.io/gh/apache/iotdb/pull/13239?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fpipe%2Freceiver%2Fvisitor%2FPipeStatementDataTypeConvertExecutionVisitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcGlwZS9yZWNlaXZlci92aXNpdG9yL1BpcGVTdGF0ZW1lbnREYXRhVHlwZUNvbnZlcnRFeGVjdXRpb25WaXNpdG9yLmphdmE=) | 0.00% | [25 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/13239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ntainer/scan/TsFileInsertionScanDataContainer.java](https://app.codecov.io/gh/apache/iotdb/pull/13239?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fpipe%2Fevent%2Fcommon%2Ftsfile%2Fcontainer%2Fscan%2FTsFileInsertionScanDataContainer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcGlwZS9ldmVudC9jb21tb24vdHNmaWxlL2NvbnRhaW5lci9zY2FuL1RzRmlsZUluc2VydGlvblNjYW5EYXRhQ29udGFpbmVyLmphdmE=) | 0.00% | [11 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/13239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #13239 +/- ##
============================================
- Coverage 41.24% 41.23% -0.01%
Complexity 71 71
============================================
Files 3838 3838
Lines 237159 237194 +35
Branches 28590 28598 +8
============================================
- Hits 97814 97809 -5
- Misses 139345 139385 +40
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/iotdb/pull/13239?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Pipe: Convert tsfile to tablets on data sync receiver when data type / aligned type mismatch detected [iotdb]
Posted by "SteveYurongSu (via GitHub)" <gi...@apache.org>.
SteveYurongSu merged PR #13239:
URL: https://github.com/apache/iotdb/pull/13239
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org