You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Brian Havard <br...@kheldar.apana.org.au> on 1999/10/21 18:00:18 UTC
Re: cvs commit: apache-2.0/src/lib/apr/threadproc/unix thread.c threadcancel.c threadpriv.c threadproc.h
On 21 Oct 1999 14:31:29 -0000, rbb@hyperreal.org wrote:
>rbb 99/10/21 07:31:29
>
> Modified: src/lib/apr/include apr_portable.h
> src/lib/apr/locks/unix intraproc.c locks.c locks.h
> src/lib/apr/threadproc/unix thread.c threadcancel.c
> threadpriv.c threadproc.h
> Log:
> Modify APR so that if we build without threads, we do not create no-op
> functions.
>
> Revision Changes Path
> 1.9 +13 -3 apache-2.0/src/lib/apr/include/apr_portable.h
>
> Index: apr_portable.h
> ===================================================================
> RCS file: /home/cvs/apache-2.0/src/lib/apr/include/apr_portable.h,v
> retrieving revision 1.8
> retrieving revision 1.9
> diff -u -r1.8 -r1.9
> --- apr_portable.h 1999/10/11 17:51:47 1.8
> +++ apr_portable.h 1999/10/21 14:31:19 1.9
[...]
> +#if APR_HAS_THREADS && HAVE_PTHREAD_H
> +ap_status_t ap_get_os_thread(ap_os_thread_t *, ap_thread_t *);
> ap_status_t ap_get_os_threadkey(ap_os_threadkey_t *, ap_key_t *);
> +#endif
Hang on, you can't use tests for pthreads outside of unix specific code. I
think we need a bit more abstraction for the "do we have threads" test.
--
______________________________________________________________________________
| Brian Havard | "He is not the messiah! |
| brianh@kheldar.apana.org.au | He's a very naughty boy!" - Life of Brian |
------------------------------------------------------------------------------
Re: cvs commit: apache-2.0/src/lib/apr/threadproc/unix thread.c
threadcancel.c threadpriv.c threadproc.h
Posted by Ryan Bloom <rb...@raleigh.ibm.com>.
> > +#if APR_HAS_THREADS && HAVE_PTHREAD_H
> > +ap_status_t ap_get_os_thread(ap_os_thread_t *, ap_thread_t *);
> > ap_status_t ap_get_os_threadkey(ap_os_threadkey_t *, ap_key_t *);
> > +#endif
>
> Hang on, you can't use tests for pthreads outside of unix specific code. I
> think we need a bit more abstraction for the "do we have threads" test.
Sorry, My bad. I'll fix this ASAP. Not paying enough attention this
week. I promise, I'll be more with it when I get back.
Ryan
_______________________________________________________________________
Ryan Bloom rbb@raleigh.ibm.com
4205 S Miami Blvd
RTP, NC 27709 It's a beautiful sight to see good dancers
doing simple steps. It's a painful sight to
see beginners doing complicated patterns.