[jira] [Commented] (YARN-3844) Make hadoop-yarn-project Native code -Wall-clean

["Colin Patrick McCabe (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14609240#comment-14609240 ] 

Colin Patrick McCabe commented on YARN-3844:
--------------------------------------------

Thanks for looking at this, Alan.

{code}
      printf("FAIL: process %s pid %ld did not exit\n", (long)cmd, child);
{code}
This doesn't seem correct.  Casting the {{cmd}} string to a long?

I would prefer to cast the pid_t variables to {{long long}} rather than {{long}}, to be completely sure.

> Make hadoop-yarn-project Native code -Wall-clean
> ------------------------------------------------
>
>                 Key: YARN-3844
>                 URL: https://issues.apache.org/jira/browse/YARN-3844
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: build
>    Affects Versions: 2.7.0
>         Environment: As we specify -Wall as a default compilation flag, it would be helpful if the Native code was -Wall-clean
>            Reporter: Alan Burlison
>            Assignee: Alan Burlison
>         Attachments: YARN-3844.001.patch, YARN-3844.002.patch, YARN-3844.004.patch
>
>
> As we specify -Wall as a default compilation flag, it would be helpful if the Native code was -Wall-clean



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)