[GitHub] [beam] dpcollins-google commented on a change in pull request #13920: [BEAM-11659] Implement Pub/Sub Lite Table Provider

[GitBox <gi...@apache.org>]

dpcollins-google commented on a change in pull request #13920:
URL: https://github.com/apache/beam/pull/13920#discussion_r584431988



##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/Schema.java
##########
@@ -949,6 +950,40 @@ public int hashCode() {
             getMetadata()
           });
     }
+
+    @Override
+    public String toString() {

Review comment:
       This is FieldType, without it, its just a dump of all the fields in a json-ish structure, which makes it hard to determine at a glance what is going on in debug prints, and makes it not a great method to present to end users when saying "this field is badly formatted". This makes the output very similar to the DDL you would have to type to describe a field of this type.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org