You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by "Brock Noland (JIRA)" <ji...@apache.org> on 2012/08/20 20:43:37 UTC

[jira] [Created] (FLUME-1496) TestFileChannel is bloated

Brock Noland created FLUME-1496:
-----------------------------------

             Summary: TestFileChannel is bloated
                 Key: FLUME-1496
                 URL: https://issues.apache.org/jira/browse/FLUME-1496
             Project: Flume
          Issue Type: Improvement
          Components: Channel
            Reporter: Brock Noland
            Assignee: Brock Noland
            Priority: Minor


TestFileChannel is quite large and it's only going to grow. We should factor out common code and break up the class into logical parts.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (FLUME-1496) TestFileChannel is bloated

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FLUME-1496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446557#comment-13446557 ] 

Hudson commented on FLUME-1496:
-------------------------------

Integrated in flume-1.3.0 #5 (See [https://builds.apache.org/job/flume-1.3.0/5/])
    FLUME-1496: TestFileChannel is bloated (Revision fc282f7ea44839437fc34a026d8fb7e59d53466d)

     Result = FAILURE
brock : http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git;a=summary&a=commit&h=fc282f7ea44839437fc34a026d8fb7e59d53466d
Files : 
* flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannel.java
* flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestUtils.java

                
> TestFileChannel is bloated
> --------------------------
>
>                 Key: FLUME-1496
>                 URL: https://issues.apache.org/jira/browse/FLUME-1496
>             Project: Flume
>          Issue Type: Improvement
>          Components: Channel
>            Reporter: Brock Noland
>            Assignee: Hari Shreedharan
>            Priority: Minor
>             Fix For: v1.3.0
>
>         Attachments: FLUME-1496-1.patch, FLUME-1496.patch
>
>
> TestFileChannel is quite large and it's only going to grow. We should factor out common code and break up the class into logical parts.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (FLUME-1496) TestFileChannel is bloated

Posted by "Brock Noland (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FLUME-1496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13442564#comment-13442564 ] 

Brock Noland commented on FLUME-1496:
-------------------------------------

Go for it!
                
> TestFileChannel is bloated
> --------------------------
>
>                 Key: FLUME-1496
>                 URL: https://issues.apache.org/jira/browse/FLUME-1496
>             Project: Flume
>          Issue Type: Improvement
>          Components: Channel
>            Reporter: Brock Noland
>            Assignee: Brock Noland
>            Priority: Minor
>
> TestFileChannel is quite large and it's only going to grow. We should factor out common code and break up the class into logical parts.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (FLUME-1496) TestFileChannel is bloated

Posted by "Hari Shreedharan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FLUME-1496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hari Shreedharan reassigned FLUME-1496:
---------------------------------------

    Assignee: Hari Shreedharan  (was: Brock Noland)
    
> TestFileChannel is bloated
> --------------------------
>
>                 Key: FLUME-1496
>                 URL: https://issues.apache.org/jira/browse/FLUME-1496
>             Project: Flume
>          Issue Type: Improvement
>          Components: Channel
>            Reporter: Brock Noland
>            Assignee: Hari Shreedharan
>            Priority: Minor
>
> TestFileChannel is quite large and it's only going to grow. We should factor out common code and break up the class into logical parts.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (FLUME-1496) TestFileChannel is bloated

Posted by "Hari Shreedharan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FLUME-1496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hari Shreedharan updated FLUME-1496:
------------------------------------

    Attachment: FLUME-1496-1.patch
    
> TestFileChannel is bloated
> --------------------------
>
>                 Key: FLUME-1496
>                 URL: https://issues.apache.org/jira/browse/FLUME-1496
>             Project: Flume
>          Issue Type: Improvement
>          Components: Channel
>            Reporter: Brock Noland
>            Assignee: Hari Shreedharan
>            Priority: Minor
>         Attachments: FLUME-1496-1.patch, FLUME-1496.patch
>
>
> TestFileChannel is quite large and it's only going to grow. We should factor out common code and break up the class into logical parts.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (FLUME-1496) TestFileChannel is bloated

Posted by "Hari Shreedharan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FLUME-1496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13442586#comment-13442586 ] 

Hari Shreedharan commented on FLUME-1496:
-----------------------------------------

Thanks, assigned in particular.
                
> TestFileChannel is bloated
> --------------------------
>
>                 Key: FLUME-1496
>                 URL: https://issues.apache.org/jira/browse/FLUME-1496
>             Project: Flume
>          Issue Type: Improvement
>          Components: Channel
>            Reporter: Brock Noland
>            Assignee: Hari Shreedharan
>            Priority: Minor
>
> TestFileChannel is quite large and it's only going to grow. We should factor out common code and break up the class into logical parts.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (FLUME-1496) TestFileChannel is bloated

Posted by "Hari Shreedharan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FLUME-1496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13442558#comment-13442558 ] 

Hari Shreedharan commented on FLUME-1496:
-----------------------------------------

Brock - I know you are working on the Protobufs patch, so would it be ok if I take this over? 
                
> TestFileChannel is bloated
> --------------------------
>
>                 Key: FLUME-1496
>                 URL: https://issues.apache.org/jira/browse/FLUME-1496
>             Project: Flume
>          Issue Type: Improvement
>          Components: Channel
>            Reporter: Brock Noland
>            Assignee: Brock Noland
>            Priority: Minor
>
> TestFileChannel is quite large and it's only going to grow. We should factor out common code and break up the class into logical parts.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (FLUME-1496) TestFileChannel is bloated

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FLUME-1496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446566#comment-13446566 ] 

Hudson commented on FLUME-1496:
-------------------------------

Integrated in flume-trunk #291 (See [https://builds.apache.org/job/flume-trunk/291/])
    FLUME-1496: TestFileChannel is bloated (Revision 82aa5fc16dac3751b78f85fbe21b8c805dbffbcc)

     Result = SUCCESS
brock : http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git;a=summary&a=commit&h=82aa5fc16dac3751b78f85fbe21b8c805dbffbcc
Files : 
* flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannel.java
* flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestUtils.java

                
> TestFileChannel is bloated
> --------------------------
>
>                 Key: FLUME-1496
>                 URL: https://issues.apache.org/jira/browse/FLUME-1496
>             Project: Flume
>          Issue Type: Improvement
>          Components: Channel
>            Reporter: Brock Noland
>            Assignee: Hari Shreedharan
>            Priority: Minor
>             Fix For: v1.3.0
>
>         Attachments: FLUME-1496-1.patch, FLUME-1496.patch
>
>
> TestFileChannel is quite large and it's only going to grow. We should factor out common code and break up the class into logical parts.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (FLUME-1496) TestFileChannel is bloated

Posted by "Hari Shreedharan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FLUME-1496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hari Shreedharan updated FLUME-1496:
------------------------------------

    Attachment: FLUME-1496.patch
    
> TestFileChannel is bloated
> --------------------------
>
>                 Key: FLUME-1496
>                 URL: https://issues.apache.org/jira/browse/FLUME-1496
>             Project: Flume
>          Issue Type: Improvement
>          Components: Channel
>            Reporter: Brock Noland
>            Assignee: Hari Shreedharan
>            Priority: Minor
>         Attachments: FLUME-1496.patch
>
>
> TestFileChannel is quite large and it's only going to grow. We should factor out common code and break up the class into logical parts.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira