You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chi Zhang <ch...@gmail.com> on 2015/09/25 01:39:14 UTC
Review Request 38743: files: fix potential fd leaks under error
conditions.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38743/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
files: fix potential fd leaks under error conditions.
Diffs
-----
src/files/files.cpp 1d4b1e6d2fcd99321084515f538aa357f8d9b305
Diff: https://reviews.apache.org/r/38743/diff/
Testing
-------
make check
Thanks,
Chi Zhang
Re: Review Request 38743: files: fix potential fd leaks under error
conditions.
Posted by Chi Zhang <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38743/
-----------------------------------------------------------
(Updated Sept. 25, 2015, 8:34 p.m.)
Review request for mesos.
Bugs: MESOS-3519
https://issues.apache.org/jira/browse/MESOS-3519
Repository: mesos
Description
-------
files: fix potential fd leaks under error conditions.
Diffs
-----
src/files/files.cpp 1d4b1e6d2fcd99321084515f538aa357f8d9b305
Diff: https://reviews.apache.org/r/38743/diff/
Testing
-------
make check
Thanks,
Chi Zhang
Re: Review Request 38743: files: fix potential fd leaks under error
conditions.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38743/#review100511
-----------------------------------------------------------
Ship it!
Can't wait to have a ref-counted abstraction to avoid this!
- Ben Mahler
On Sept. 24, 2015, 11:39 p.m., Chi Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38743/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2015, 11:39 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> files: fix potential fd leaks under error conditions.
>
>
> Diffs
> -----
>
> src/files/files.cpp 1d4b1e6d2fcd99321084515f538aa357f8d9b305
>
> Diff: https://reviews.apache.org/r/38743/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chi Zhang
>
>