You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by ilooner <gi...@git.apache.org> on 2018/01/31 03:10:49 UTC

[GitHub] drill pull request #1103: DRILL-6124: Fixed possible NPE when no injection s...

GitHub user ilooner opened a pull request:

    https://github.com/apache/drill/pull/1103

    DRILL-6124: Fixed possible NPE when no injection site is defined for …

    …"partitioner-sender-latch" in PartitionerDecorator.
    
    ```
    injector.getLatch(context.getExecutionControls(), "partitioner-sender-latch");
    ```
    
    Can return null if the user does not have the appropriate injection defined in their config.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ilooner/drill DRILL-6124

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/1103.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1103
    
----
commit fee42e0ff8d4d81c76a023c58a48d851eb8da88b
Author: Timothy Farkas <ti...@...>
Date:   2018-01-30T22:27:05Z

    DRILL-6124: Fixed possible NPE when no injection site is defined for "partitioner-sender-latch" in PartitionerDecorator.

----


---

[GitHub] drill issue #1103: DRILL-6124: Fixed possible NPE when no injection site is ...

Posted by ilooner <gi...@git.apache.org>.

Github user ilooner commented on the issue:

    https://github.com/apache/drill/pull/1103
  
    @sachouche @arina-ielchiieva 


---

[GitHub] drill issue #1103: DRILL-6124: Fixed possible NPE when no injection site is ...

Posted by ilooner <gi...@git.apache.org>.

Github user ilooner commented on the issue:

    https://github.com/apache/drill/pull/1103
  
    You are right @arina-ielchiieva . Thanks for catching this, I will close the PR and mark the jira as invalid.


---

[GitHub] drill pull request #1103: DRILL-6124: Fixed possible NPE when no injection s...

Posted by ilooner <gi...@git.apache.org>.

Github user ilooner closed the pull request at:

    https://github.com/apache/drill/pull/1103


---

[GitHub] drill issue #1103: DRILL-6124: Fixed possible NPE when no injection site is ...

Posted by arina-ielchiieva <gi...@git.apache.org>.

Github user arina-ielchiieva commented on the issue:

    https://github.com/apache/drill/pull/1103
  
    @ilooner it looks like if latch is not found, execution control will return dummy latch [1]? If I am missing something, please explain.
    
    [1] https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/testing/ExecutionControls.java#L206


---