You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2023/01/10 22:29:34 UTC
[GitHub] [nifi] greyp9 commented on a diff in pull request #6833: NIFI-10993 - PublishKafkaRecord should use correct record schema
greyp9 commented on code in PR #6833:
URL: https://github.com/apache/nifi/pull/6833#discussion_r1066408810
##########
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-2-6-processors/src/test/java/org/apache/nifi/processors/kafka/pubsub/TestPublishKafkaMock.java:
##########
@@ -368,7 +511,7 @@ private PublisherLease getPublisherLease(final Collection<ProducerRecord<byte[],
true,
patternAttributeName,
UTF_8,
- null,
+ publishStrategy,
Review Comment:
In testing the code change, discovered this unit test was ignoring the specified publish strategy. So several modified test cases in addition to the new one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org