You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2021/12/20 09:30:33 UTC
[GitHub] [james-project] Arsnael commented on a change in pull request #803: JAMES-3680 Fix JMAP authentication strategies configuration
Arsnael commented on a change in pull request #803:
URL: https://github.com/apache/james-project/pull/803#discussion_r772207406
##########
File path: server/container/guice/protocols/jmap/src/main/java/org/apache/james/jmap/draft/JMAPModule.java
##########
@@ -207,7 +207,7 @@ JMAPDraftConfiguration provideDraftConfiguration(PropertiesProvider propertiesPr
.keystoreType(configuration.getString("tls.keystoreType", null))
.secret(configuration.getString("tls.secret", null))
.jwtPublicKeyPem(loadPublicKey(fileSystem, ImmutableList.copyOf(configuration.getStringArray("jwt.publickeypem.url"))))
- .authenticationStrategies(Optional.ofNullable(configuration.getList(String.class, "authentication.strategy.draft", null)))
+ .authenticationStrategies(Optional.ofNullable(ImmutableList.copyOf(configuration.getStringArray("authentication.strategy.draft"))))
Review comment:
Optional.of then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org