You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "shreemaan-abhishek (via GitHub)" <gi...@apache.org> on 2023/04/20 07:24:31 UTC
[GitHub] [apisix] shreemaan-abhishek opened a new pull request, #9345: feat: allow degradation
shreemaan-abhishek opened a new pull request, #9345:
URL: https://github.com/apache/apisix/pull/9345
### Description
<!-- Please include a summary of the change and which issue is fixed. -->
<!-- Please also include relevant motivation and context. -->
Fixes #9233
### Checklist
- [ ] I have explained the need for this PR and the problem it solves
- [ ] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [ ] I have updated the documentation to reflect this change
- [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 merged pull request #9345: feat: allow degradation
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 merged PR #9345:
URL: https://github.com/apache/apisix/pull/9345
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Gallardot commented on pull request #9345: feat: allow degradation
Posted by "Gallardot (via GitHub)" <gi...@apache.org>.
Gallardot commented on PR #9345:
URL: https://github.com/apache/apisix/pull/9345#issuecomment-1518917205
@shreemaan-abhishek Thank you for your contribution. Notice that CI failed. I've retried the failed job, but it still doesn't work. Before merging, you need to fix CI. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] soulbird commented on pull request #9345: feat: allow degradation
Posted by "soulbird (via GitHub)" <gi...@apache.org>.
soulbird commented on PR #9345:
URL: https://github.com/apache/apisix/pull/9345#issuecomment-1516013067
Pls update doc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #9345: feat: allow degradation
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on code in PR #9345:
URL: https://github.com/apache/apisix/pull/9345#discussion_r1174903027
##########
t/plugin/forward-auth.t:
##########
@@ -206,6 +206,42 @@ property "request_method" validation failed: matches none of the enum values
"uri": "/ping"
}]],
},
+ {
+ url = "/apisix/admin/routes/4",
+ data = [[{
+ "plugins": {
+ "forward-auth": {
+ "uri": "http://127.0.0.1:1964/auth",
Review Comment:
Using the nonexistent port is very unstable, could you try to use the `serverless-pre-function` plugin and `core.response.exit(444)` to mock the unavailable auth server
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] shreemaan-abhishek commented on pull request #9345: feat: allow degradation
Posted by "shreemaan-abhishek (via GitHub)" <gi...@apache.org>.
shreemaan-abhishek commented on PR #9345:
URL: https://github.com/apache/apisix/pull/9345#issuecomment-1521843570
Looks like flaky failure, please re-run failed tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org