You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Velmurugan Periasamy <vp...@hortonworks.com> on 2015/04/23 03:30:12 UTC
Review Request 33462: AMBARI-10676: Patch for implementing DB
connectivity
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33462/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jaimin Jetly, Jayush Luniya, Mahadev Konar, Sumit Mohanty, and Yusaku Sako.
Bugs: AMBARI-10676
https://issues.apache.org/jira/browse/AMBARI-10676
Repository: ambari
Description
-------
Logic for DB connection test
Diffs
-----
ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/admin-properties.xml aefb200
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py e2b8ba8
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py 391df2a
Diff: https://reviews.apache.org/r/33462/diff/
Testing
-------
-- tested functionality locally
-- verified python unit tests
-----------------------------------------------------------------------
Ran 232 tests in 6.758s
OK
----------------------------------------------------------------------
Total run:675
Total errors:0
Total failures:0
OK
Thanks,
Velmurugan Periasamy
Re: Review Request 33462: AMBARI-10676: Patch for implementing DB
connectivity
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33462/#review81274
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py
<https://reviews.apache.org/r/33462/#comment131565>
This function is not being invoked anywhere. Also can you rename test_db_connection_ambaricmd() function name to something like validate_db_connection().
- Jayush Luniya
On April 23, 2015, 1:30 a.m., Velmurugan Periasamy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33462/
> -----------------------------------------------------------
>
> (Updated April 23, 2015, 1:30 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jaimin Jetly, Jayush Luniya, Mahadev Konar, Sumit Mohanty, and Yusaku Sako.
>
>
> Bugs: AMBARI-10676
> https://issues.apache.org/jira/browse/AMBARI-10676
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Logic for DB connection test
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/admin-properties.xml aefb200
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py e2b8ba8
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py 391df2a
>
> Diff: https://reviews.apache.org/r/33462/diff/
>
>
> Testing
> -------
>
> -- tested functionality locally
> -- verified python unit tests
>
> -----------------------------------------------------------------------
> Ran 232 tests in 6.758s
>
> OK
> ----------------------------------------------------------------------
> Total run:675
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Velmurugan Periasamy
>
>
Re: Review Request 33462: AMBARI-10676: Patch for implementing DB
connectivity
Posted by Jayush Luniya <jl...@hortonworks.com>.
> On April 23, 2015, 6:40 a.m., Jayush Luniya wrote:
> > Based on what I see in this patch, it looks like DB connection check is run during install/start execution. We should be validating this at "Customize Services" step before starting the deployment. Take a look at how this is done for Hive/Oozie. If you select one of the "Existing MySQL Database" type, you will see that it displays "Test Connection" button which if click invokes a check_host command with check_execute_list":"db_connection_check" to validate the DB connection properties. We should do similar changes for RANGER.
Also there are no unit tests in the patch.
- Jayush
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33462/#review81276
-----------------------------------------------------------
On April 23, 2015, 1:30 a.m., Velmurugan Periasamy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33462/
> -----------------------------------------------------------
>
> (Updated April 23, 2015, 1:30 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jaimin Jetly, Jayush Luniya, Mahadev Konar, Sumit Mohanty, and Yusaku Sako.
>
>
> Bugs: AMBARI-10676
> https://issues.apache.org/jira/browse/AMBARI-10676
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Logic for DB connection test
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/admin-properties.xml aefb200
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py e2b8ba8
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py 391df2a
>
> Diff: https://reviews.apache.org/r/33462/diff/
>
>
> Testing
> -------
>
> -- tested functionality locally
> -- verified python unit tests
>
> -----------------------------------------------------------------------
> Ran 232 tests in 6.758s
>
> OK
> ----------------------------------------------------------------------
> Total run:675
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Velmurugan Periasamy
>
>
Re: Review Request 33462: AMBARI-10676: Patch for implementing DB
connectivity
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33462/#review81276
-----------------------------------------------------------
Based on what I see in this patch, it looks like DB connection check is run during install/start execution. We should be validating this at "Customize Services" step before starting the deployment. Take a look at how this is done for Hive/Oozie. If you select one of the "Existing MySQL Database" type, you will see that it displays "Test Connection" button which if click invokes a check_host command with check_execute_list":"db_connection_check" to validate the DB connection properties. We should do similar changes for RANGER.
- Jayush Luniya
On April 23, 2015, 1:30 a.m., Velmurugan Periasamy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33462/
> -----------------------------------------------------------
>
> (Updated April 23, 2015, 1:30 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jaimin Jetly, Jayush Luniya, Mahadev Konar, Sumit Mohanty, and Yusaku Sako.
>
>
> Bugs: AMBARI-10676
> https://issues.apache.org/jira/browse/AMBARI-10676
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Logic for DB connection test
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/admin-properties.xml aefb200
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py e2b8ba8
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py 391df2a
>
> Diff: https://reviews.apache.org/r/33462/diff/
>
>
> Testing
> -------
>
> -- tested functionality locally
> -- verified python unit tests
>
> -----------------------------------------------------------------------
> Ran 232 tests in 6.758s
>
> OK
> ----------------------------------------------------------------------
> Total run:675
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Velmurugan Periasamy
>
>