You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/10/06 13:11:51 UTC
[GitHub] [incubator-nuttx-apps] davids5 opened a new pull request #419: ipcfg:Version the binary structure
davids5 opened a new pull request #419:
URL: https://github.com/apache/incubator-nuttx-apps/pull/419
## Summary
This adds a version for the binary file structure.
## Impact
Should be none as this is not used yet.
## Testing
inspection.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] davids5 commented on a change in pull request #419: ipcfg:Version the binary structure
Posted by GitBox <gi...@apache.org>.
davids5 commented on a change in pull request #419:
URL: https://github.com/apache/incubator-nuttx-apps/pull/419#discussion_r500278866
##########
File path: fsutils/ipcfg/ipcfg.h
##########
@@ -49,7 +50,8 @@
struct ipcfg_header_s
{
- uint8_t next; /* Offset to the next IP configuration record */
+ uint8_t next; /* Offset to the next IP configuration record */
+ uint8_t version; /* For binary compatibility */
sa_family_t type; /* Either AF_INET or AF_INET6 */
};
Review comment:
Yes. The ides is that returning to factory default are better than using corrupted data.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] patacongo commented on a change in pull request #419: ipcfg:Version the binary structure
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #419:
URL: https://github.com/apache/incubator-nuttx-apps/pull/419#discussion_r500276324
##########
File path: fsutils/ipcfg/ipcfg.h
##########
@@ -49,7 +50,8 @@
struct ipcfg_header_s
{
- uint8_t next; /* Offset to the next IP configuration record */
+ uint8_t next; /* Offset to the next IP configuration record */
+ uint8_t version; /* For binary compatibility */
sa_family_t type; /* Either AF_INET or AF_INET6 */
};
Review comment:
This is really insufficient. If the version number changes, then the size will also change. This won't work in most cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] patacongo merged pull request #419: ipcfg:Version the binary structure
Posted by GitBox <gi...@apache.org>.
patacongo merged pull request #419:
URL: https://github.com/apache/incubator-nuttx-apps/pull/419
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] patacongo commented on a change in pull request #419: ipcfg:Version the binary structure
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #419:
URL: https://github.com/apache/incubator-nuttx-apps/pull/419#discussion_r500277093
##########
File path: fsutils/ipcfg/ipcfg.h
##########
@@ -49,7 +50,8 @@
struct ipcfg_header_s
{
- uint8_t next; /* Offset to the next IP configuration record */
+ uint8_t next; /* Offset to the next IP configuration record */
+ uint8_t version; /* For binary compatibility */
sa_family_t type; /* Either AF_INET or AF_INET6 */
};
Review comment:
Nevermind. I see that you ignore the data if the version number is bad. That is okay if you don't try to read it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org