You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/21 03:12:56 UTC

[GitHub] [flink] HuangXingBo opened a new pull request #10911: [FLINK-15700][python][doc] Improves the Python API Tutorial doc

HuangXingBo opened a new pull request #10911: [FLINK-15700][python][doc] Improves the Python API Tutorial doc
URL: https://github.com/apache/flink/pull/10911
 
 
   ## What is the purpose of the change
   
   *This pull request adds the content of preparing input data and how to see the result in Python API tutorial*
   
   
   ## Brief change log
   
     - *Adds the content of preparing input data and how to see the result in python_table_api.md*
     - *Adds the content of preparing input data and how to see the result in python_table_api.zh.md*
   
   ## Verifying this change
   
   *This change is a trivial rework / code cleanup without any test coverage.*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (docs)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] hequn8128 commented on a change in pull request #10911: [FLINK-15700][python][doc] Improves the Python API Tutorial doc

Posted by GitBox <gi...@apache.org>.
hequn8128 commented on a change in pull request #10911: [FLINK-15700][python][doc] Improves the Python API Tutorial doc
URL: https://github.com/apache/flink/pull/10911#discussion_r368829260
 
 

 ##########
 File path: docs/getting-started/walkthroughs/python_table_api.md
 ##########
 @@ -142,8 +141,13 @@ t_env.execute("tutorial_job")
 {% endhighlight %}
 
 ## Executing a Flink Python Table API Program
+Firstly, you need to prepare input data in "/tmp/input" file.You can choose the following command line to prepare input data:
+
+{% highlight bash %}
+$ echo "flink\npyflink\nflink">/tmp/input
 
 Review comment:
   Add a blank before and after the `>`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10911: [FLINK-15700][python][doc] Improves the Python API Tutorial doc

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10911: [FLINK-15700][python][doc] Improves the Python API Tutorial doc
URL: https://github.com/apache/flink/pull/10911#issuecomment-576500532
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 799d30c3b6824f3e80af569711f8ab7a35a06c7d (Tue Jan 21 03:16:56 UTC 2020)
   
   **Warnings:**
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-15700).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] hequn8128 commented on a change in pull request #10911: [FLINK-15700][python][doc] Improves the Python API Tutorial doc

Posted by GitBox <gi...@apache.org>.
hequn8128 commented on a change in pull request #10911: [FLINK-15700][python][doc] Improves the Python API Tutorial doc
URL: https://github.com/apache/flink/pull/10911#discussion_r368829167
 
 

 ##########
 File path: docs/getting-started/walkthroughs/python_table_api.md
 ##########
 @@ -142,8 +141,13 @@ t_env.execute("tutorial_job")
 {% endhighlight %}
 
 ## Executing a Flink Python Table API Program
+Firstly, you need to prepare input data in "/tmp/input" file.You can choose the following command line to prepare input data:
 
 Review comment:
   Maybe change "You can choose the following command line to prepare input data" to
   "You can choose the following command to prepare the input data"? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10911: [FLINK-15700][python][doc] Improves the Python API Tutorial doc

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10911: [FLINK-15700][python][doc] Improves the Python API Tutorial doc
URL: https://github.com/apache/flink/pull/10911#issuecomment-576505237
 
 
   <!--
   Meta data
   Hash:799d30c3b6824f3e80af569711f8ab7a35a06c7d Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:799d30c3b6824f3e80af569711f8ab7a35a06c7d
   -->
   ## CI report:
   
   * 799d30c3b6824f3e80af569711f8ab7a35a06c7d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] hequn8128 commented on a change in pull request #10911: [FLINK-15700][python][doc] Improves the Python API Tutorial doc

Posted by GitBox <gi...@apache.org>.
hequn8128 commented on a change in pull request #10911: [FLINK-15700][python][doc] Improves the Python API Tutorial doc
URL: https://github.com/apache/flink/pull/10911#discussion_r368829682
 
 

 ##########
 File path: docs/getting-started/walkthroughs/python_table_api.md
 ##########
 @@ -142,8 +141,13 @@ t_env.execute("tutorial_job")
 {% endhighlight %}
 
 ## Executing a Flink Python Table API Program
+Firstly, you need to prepare input data in "/tmp/input" file.You can choose the following command line to prepare input data:
+
+{% highlight bash %}
+$ echo "flink\npyflink\nflink">/tmp/input
+{% endhighlight %}
 
-You can run this example in your IDE or on the command line:
+Next, you can run this example in your IDE or on the command line(Note: if the file "/tmp/output" has been existed, you need to remove the file before running the example):
 
 Review comment:
   Remove the `in your IDE or`. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10911: [FLINK-15700][python][doc] Improves the Python API Tutorial doc

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10911: [FLINK-15700][python][doc] Improves the Python API Tutorial doc
URL: https://github.com/apache/flink/pull/10911#issuecomment-576505237
 
 
   <!--
   Meta data
   Hash:799d30c3b6824f3e80af569711f8ab7a35a06c7d Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/145303921 TriggerType:PUSH TriggerID:799d30c3b6824f3e80af569711f8ab7a35a06c7d
   Hash:799d30c3b6824f3e80af569711f8ab7a35a06c7d Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4521 TriggerType:PUSH TriggerID:799d30c3b6824f3e80af569711f8ab7a35a06c7d
   -->
   ## CI report:
   
   * 799d30c3b6824f3e80af569711f8ab7a35a06c7d Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/145303921) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4521) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] hequn8128 commented on a change in pull request #10911: [FLINK-15700][python][doc] Improves the Python API Tutorial doc

Posted by GitBox <gi...@apache.org>.
hequn8128 commented on a change in pull request #10911: [FLINK-15700][python][doc] Improves the Python API Tutorial doc
URL: https://github.com/apache/flink/pull/10911#discussion_r368828468
 
 

 ##########
 File path: docs/getting-started/walkthroughs/python_table_api.md
 ##########
 @@ -142,8 +141,13 @@ t_env.execute("tutorial_job")
 {% endhighlight %}
 
 ## Executing a Flink Python Table API Program
+Firstly, you need to prepare input data in "/tmp/input" file.You can choose the following command line to prepare input data:
 
 Review comment:
   Add a blank after the `.`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10911: [FLINK-15700][python][doc] Improves the Python API Tutorial doc

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10911: [FLINK-15700][python][doc] Improves the Python API Tutorial doc
URL: https://github.com/apache/flink/pull/10911#issuecomment-576505237
 
 
   <!--
   Meta data
   Hash:799d30c3b6824f3e80af569711f8ab7a35a06c7d Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/145303921 TriggerType:PUSH TriggerID:799d30c3b6824f3e80af569711f8ab7a35a06c7d
   Hash:799d30c3b6824f3e80af569711f8ab7a35a06c7d Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4521 TriggerType:PUSH TriggerID:799d30c3b6824f3e80af569711f8ab7a35a06c7d
   -->
   ## CI report:
   
   * 799d30c3b6824f3e80af569711f8ab7a35a06c7d Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/145303921) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4521) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] hequn8128 closed pull request #10911: [FLINK-15700][python][doc] Improves the Python API Tutorial doc

Posted by GitBox <gi...@apache.org>.
hequn8128 closed pull request #10911: [FLINK-15700][python][doc] Improves the Python API Tutorial doc
URL: https://github.com/apache/flink/pull/10911
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services