You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/17 12:55:39 UTC

[GitHub] [incubator-superset] kkucharc opened a new pull request #10932: fix: address all disabled pylint checks in charts/api.py

kkucharc opened a new pull request #10932:
URL: https://github.com/apache/incubator-superset/pull/10932


   ### SUMMARY
   Removed disabled pylint checks in `charts/api.py`:
   -  `arguments-differ` in `put()`, `delete()` and `bulk_delete()` methods isn't an issue anymore,
   - `put()` and `data()` refactored to remove disabled check ` too-many-return-statements` .
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] kkucharc commented on pull request #10932: fix: address all disabled pylint checks in charts/api.py

Posted by GitBox <gi...@apache.org>.
kkucharc commented on pull request #10932:
URL: https://github.com/apache/incubator-superset/pull/10932#issuecomment-694392777


   Thank you @dpgaspar for the review and merge :)
   cc: @willbarrett 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] dpgaspar merged pull request #10932: fix: address all disabled pylint checks in charts/api.py

Posted by GitBox <gi...@apache.org>.
dpgaspar merged pull request #10932:
URL: https://github.com/apache/incubator-superset/pull/10932


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org