You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by guo jiwei <te...@apache.org> on 2022/03/16 12:43:45 UTC

[DISCUSS] PIP-143 : Standardize Admin REST API

Hello community,

    I want to discuss refactoring and standardizing REST API. Users have
encountered several deadlock problems in the API part before, like #13666
<https://github.com/apache/pulsar/pull/13666>, #12590
<https://github.com/apache/pulsar/pull/12590>. After fixing the above two
issues, we check the related part and find that there are still numbers of
asynchronous call synchronous implementations for other functions of the
REST API. To avoid more problems, I would like to discuss the
standardization of API modules and create the PIP-142  #14365
<https://github.com/apache/pulsar/pull/14365> . Feel free to comment and
give suggestions.




Regards
Jiwei Guo (Tboy)

Re: [DISCUSS] PIP-143 : Standardize Admin REST API

Posted by mattison chao <ma...@gmail.com>.
+1

Best,
Mattison

> On Mar 22, 2022, at 9:55 AM, PengHui Li <pe...@apache.org> wrote:
> 
> +1
> 
> Penghui
> 
> On Fri, Mar 18, 2022 at 11:00 AM guo jiwei <te...@apache.org> wrote:
> 
>> Ok, I have updated the proposal number to 149.
>> https://github.com/apache/pulsar/issues/14365.
>> 
>> Regards
>> Jiwei Guo (Tboy)
>> 
>> 
>> On Wed, Mar 16, 2022 at 8:53 PM PengHui Li <pe...@apache.org> wrote:
>> 
>>> PIP-143 is this one https://github.com/apache/pulsar/issues/13761
>>> 
>>> Please peek a new proposal number
>>> 
>>> Penghui
>>> 
>>> On Wed, Mar 16, 2022 at 8:43 PM guo jiwei <te...@apache.org> wrote:
>>> 
>>>> Hello community,
>>>> 
>>>>    I want to discuss refactoring and standardizing REST API. Users
>> have
>>>> encountered several deadlock problems in the API part before, like
>> #13666
>>>> <https://github.com/apache/pulsar/pull/13666>, #12590
>>>> <https://github.com/apache/pulsar/pull/12590>. After fixing the above
>>> two
>>>> issues, we check the related part and find that there are still numbers
>>> of
>>>> asynchronous call synchronous implementations for other functions of
>> the
>>>> REST API. To avoid more problems, I would like to discuss the
>>>> standardization of API modules and create the PIP-142  #14365
>>>> <https://github.com/apache/pulsar/pull/14365> . Feel free to comment
>> and
>>>> give suggestions.
>>>> 
>>>> 
>>>> 
>>>> 
>>>> Regards
>>>> Jiwei Guo (Tboy)
>>>> 
>>> 
>> 


Re: [DISCUSS] PIP-143 : Standardize Admin REST API

Posted by PengHui Li <pe...@apache.org>.
+1

Penghui

On Fri, Mar 18, 2022 at 11:00 AM guo jiwei <te...@apache.org> wrote:

> Ok, I have updated the proposal number to 149.
> https://github.com/apache/pulsar/issues/14365.
>
> Regards
> Jiwei Guo (Tboy)
>
>
> On Wed, Mar 16, 2022 at 8:53 PM PengHui Li <pe...@apache.org> wrote:
>
> > PIP-143 is this one https://github.com/apache/pulsar/issues/13761
> >
> > Please peek a new proposal number
> >
> > Penghui
> >
> > On Wed, Mar 16, 2022 at 8:43 PM guo jiwei <te...@apache.org> wrote:
> >
> > > Hello community,
> > >
> > >     I want to discuss refactoring and standardizing REST API. Users
> have
> > > encountered several deadlock problems in the API part before, like
> #13666
> > > <https://github.com/apache/pulsar/pull/13666>, #12590
> > > <https://github.com/apache/pulsar/pull/12590>. After fixing the above
> > two
> > > issues, we check the related part and find that there are still numbers
> > of
> > > asynchronous call synchronous implementations for other functions of
> the
> > > REST API. To avoid more problems, I would like to discuss the
> > > standardization of API modules and create the PIP-142  #14365
> > > <https://github.com/apache/pulsar/pull/14365> . Feel free to comment
> and
> > > give suggestions.
> > >
> > >
> > >
> > >
> > > Regards
> > > Jiwei Guo (Tboy)
> > >
> >
>

Re: [DISCUSS] PIP-143 : Standardize Admin REST API

Posted by guo jiwei <te...@apache.org>.
Ok, I have updated the proposal number to 149.
https://github.com/apache/pulsar/issues/14365.

Regards
Jiwei Guo (Tboy)


On Wed, Mar 16, 2022 at 8:53 PM PengHui Li <pe...@apache.org> wrote:

> PIP-143 is this one https://github.com/apache/pulsar/issues/13761
>
> Please peek a new proposal number
>
> Penghui
>
> On Wed, Mar 16, 2022 at 8:43 PM guo jiwei <te...@apache.org> wrote:
>
> > Hello community,
> >
> >     I want to discuss refactoring and standardizing REST API. Users have
> > encountered several deadlock problems in the API part before, like #13666
> > <https://github.com/apache/pulsar/pull/13666>, #12590
> > <https://github.com/apache/pulsar/pull/12590>. After fixing the above
> two
> > issues, we check the related part and find that there are still numbers
> of
> > asynchronous call synchronous implementations for other functions of the
> > REST API. To avoid more problems, I would like to discuss the
> > standardization of API modules and create the PIP-142  #14365
> > <https://github.com/apache/pulsar/pull/14365> . Feel free to comment and
> > give suggestions.
> >
> >
> >
> >
> > Regards
> > Jiwei Guo (Tboy)
> >
>

Re: [DISCUSS] PIP-143 : Standardize Admin REST API

Posted by PengHui Li <pe...@apache.org>.
PIP-143 is this one https://github.com/apache/pulsar/issues/13761

Please peek a new proposal number

Penghui

On Wed, Mar 16, 2022 at 8:43 PM guo jiwei <te...@apache.org> wrote:

> Hello community,
>
>     I want to discuss refactoring and standardizing REST API. Users have
> encountered several deadlock problems in the API part before, like #13666
> <https://github.com/apache/pulsar/pull/13666>, #12590
> <https://github.com/apache/pulsar/pull/12590>. After fixing the above two
> issues, we check the related part and find that there are still numbers of
> asynchronous call synchronous implementations for other functions of the
> REST API. To avoid more problems, I would like to discuss the
> standardization of API modules and create the PIP-142  #14365
> <https://github.com/apache/pulsar/pull/14365> . Feel free to comment and
> give suggestions.
>
>
>
>
> Regards
> Jiwei Guo (Tboy)
>

Re: [DISCUSS] PIP-143 : Standardize Admin REST API

Posted by Enrico Olivelli <eo...@gmail.com>.
Il giorno mer 23 mar 2022 alle ore 13:45 guo jiwei
<te...@apache.org> ha scritto:
>
> Hi, @Enrico
>    Sorry for the inappropriate words, I will correct them immediately and
> applying in PIP.

No problem.
Thanks for this useful contribution !

Enrico

>
> Regards
> Jiwei Guo (Tboy)
>
>
> On Wed, Mar 23, 2022 at 8:28 PM Enrico Olivelli <eo...@gmail.com> wrote:
>
> > I agree that fixing all the points in which we are doing sync calls is a
> > good thing and that we should fix them.
> >
> > I won't use the name 'standardise' as it sounds to me like creating a new
> > API
> >
> > What about 'Making the REST Admin API fully async' ?
> >
> > Apart from the name I agreee with the proposal
> >
> > Enrico
> >
> > Il Mer 23 Mar 2022, 10:34 Zike Yang <zi...@apache.org> ha scritto:
> >
> > > +1
> > >
> > > Thanks,
> > > Zike Yang
> > >
> > > On Tue, Mar 22, 2022 at 8:32 PM 石宝迪 <wu...@icloud.com.invalid>
> > > wrote:
> > > >
> > > > +1
> > > >
> > > >
> > > > > 在 2022年3月22日,19:59,Haiting Jiang <ji...@apache.org> 写道:
> > > > >
> > > > > +1
> > > > >
> > > > > Thanks,
> > > > > Haiting
> > > > >
> > > > >> On 2022/03/16 12:43:45 guo jiwei wrote:
> > > > >> Hello community,
> > > > >>
> > > > >>    I want to discuss refactoring and standardizing REST API. Users
> > > have
> > > > >> encountered several deadlock problems in the API part before, like
> > > #13666
> > > > >> <https://github.com/apache/pulsar/pull/13666>, #12590
> > > > >> <https://github.com/apache/pulsar/pull/12590>. After fixing the
> > > above two
> > > > >> issues, we check the related part and find that there are still
> > > numbers of
> > > > >> asynchronous call synchronous implementations for other functions of
> > > the
> > > > >> REST API. To avoid more problems, I would like to discuss the
> > > > >> standardization of API modules and create the PIP-142  #14365
> > > > >> <https://github.com/apache/pulsar/pull/14365> . Feel free to
> > comment
> > > and
> > > > >> give suggestions.
> > > > >>
> > > > >>
> > > > >>
> > > > >>
> > > > >> Regards
> > > > >> Jiwei Guo (Tboy)
> > > > >>
> > >
> >

Re: [DISCUSS] PIP-143 : Standardize Admin REST API

Posted by guo jiwei <te...@apache.org>.
Hi, @Enrico
   Sorry for the inappropriate words, I will correct them immediately and
applying in PIP.

Regards
Jiwei Guo (Tboy)


On Wed, Mar 23, 2022 at 8:28 PM Enrico Olivelli <eo...@gmail.com> wrote:

> I agree that fixing all the points in which we are doing sync calls is a
> good thing and that we should fix them.
>
> I won't use the name 'standardise' as it sounds to me like creating a new
> API
>
> What about 'Making the REST Admin API fully async' ?
>
> Apart from the name I agreee with the proposal
>
> Enrico
>
> Il Mer 23 Mar 2022, 10:34 Zike Yang <zi...@apache.org> ha scritto:
>
> > +1
> >
> > Thanks,
> > Zike Yang
> >
> > On Tue, Mar 22, 2022 at 8:32 PM 石宝迪 <wu...@icloud.com.invalid>
> > wrote:
> > >
> > > +1
> > >
> > >
> > > > 在 2022年3月22日,19:59,Haiting Jiang <ji...@apache.org> 写道:
> > > >
> > > > +1
> > > >
> > > > Thanks,
> > > > Haiting
> > > >
> > > >> On 2022/03/16 12:43:45 guo jiwei wrote:
> > > >> Hello community,
> > > >>
> > > >>    I want to discuss refactoring and standardizing REST API. Users
> > have
> > > >> encountered several deadlock problems in the API part before, like
> > #13666
> > > >> <https://github.com/apache/pulsar/pull/13666>, #12590
> > > >> <https://github.com/apache/pulsar/pull/12590>. After fixing the
> > above two
> > > >> issues, we check the related part and find that there are still
> > numbers of
> > > >> asynchronous call synchronous implementations for other functions of
> > the
> > > >> REST API. To avoid more problems, I would like to discuss the
> > > >> standardization of API modules and create the PIP-142  #14365
> > > >> <https://github.com/apache/pulsar/pull/14365> . Feel free to
> comment
> > and
> > > >> give suggestions.
> > > >>
> > > >>
> > > >>
> > > >>
> > > >> Regards
> > > >> Jiwei Guo (Tboy)
> > > >>
> >
>

Re: [DISCUSS] PIP-143 : Standardize Admin REST API

Posted by Enrico Olivelli <eo...@gmail.com>.
I agree that fixing all the points in which we are doing sync calls is a
good thing and that we should fix them.

I won't use the name 'standardise' as it sounds to me like creating a new
API

What about 'Making the REST Admin API fully async' ?

Apart from the name I agreee with the proposal

Enrico

Il Mer 23 Mar 2022, 10:34 Zike Yang <zi...@apache.org> ha scritto:

> +1
>
> Thanks,
> Zike Yang
>
> On Tue, Mar 22, 2022 at 8:32 PM 石宝迪 <wu...@icloud.com.invalid>
> wrote:
> >
> > +1
> >
> >
> > > 在 2022年3月22日,19:59,Haiting Jiang <ji...@apache.org> 写道:
> > >
> > > +1
> > >
> > > Thanks,
> > > Haiting
> > >
> > >> On 2022/03/16 12:43:45 guo jiwei wrote:
> > >> Hello community,
> > >>
> > >>    I want to discuss refactoring and standardizing REST API. Users
> have
> > >> encountered several deadlock problems in the API part before, like
> #13666
> > >> <https://github.com/apache/pulsar/pull/13666>, #12590
> > >> <https://github.com/apache/pulsar/pull/12590>. After fixing the
> above two
> > >> issues, we check the related part and find that there are still
> numbers of
> > >> asynchronous call synchronous implementations for other functions of
> the
> > >> REST API. To avoid more problems, I would like to discuss the
> > >> standardization of API modules and create the PIP-142  #14365
> > >> <https://github.com/apache/pulsar/pull/14365> . Feel free to comment
> and
> > >> give suggestions.
> > >>
> > >>
> > >>
> > >>
> > >> Regards
> > >> Jiwei Guo (Tboy)
> > >>
>

Re: [DISCUSS] PIP-143 : Standardize Admin REST API

Posted by Zike Yang <zi...@apache.org>.
+1

Thanks,
Zike Yang

On Tue, Mar 22, 2022 at 8:32 PM 石宝迪 <wu...@icloud.com.invalid> wrote:
>
> +1
>
>
> > 在 2022年3月22日,19:59,Haiting Jiang <ji...@apache.org> 写道:
> >
> > +1
> >
> > Thanks,
> > Haiting
> >
> >> On 2022/03/16 12:43:45 guo jiwei wrote:
> >> Hello community,
> >>
> >>    I want to discuss refactoring and standardizing REST API. Users have
> >> encountered several deadlock problems in the API part before, like #13666
> >> <https://github.com/apache/pulsar/pull/13666>, #12590
> >> <https://github.com/apache/pulsar/pull/12590>. After fixing the above two
> >> issues, we check the related part and find that there are still numbers of
> >> asynchronous call synchronous implementations for other functions of the
> >> REST API. To avoid more problems, I would like to discuss the
> >> standardization of API modules and create the PIP-142  #14365
> >> <https://github.com/apache/pulsar/pull/14365> . Feel free to comment and
> >> give suggestions.
> >>
> >>
> >>
> >>
> >> Regards
> >> Jiwei Guo (Tboy)
> >>

Re: [DISCUSS] PIP-143 : Standardize Admin REST API

Posted by 石宝迪 <wu...@icloud.com.INVALID>.
+1


> 在 2022年3月22日,19:59,Haiting Jiang <ji...@apache.org> 写道:
> 
> +1
> 
> Thanks,
> Haiting
> 
>> On 2022/03/16 12:43:45 guo jiwei wrote:
>> Hello community,
>> 
>>    I want to discuss refactoring and standardizing REST API. Users have
>> encountered several deadlock problems in the API part before, like #13666
>> <https://github.com/apache/pulsar/pull/13666>, #12590
>> <https://github.com/apache/pulsar/pull/12590>. After fixing the above two
>> issues, we check the related part and find that there are still numbers of
>> asynchronous call synchronous implementations for other functions of the
>> REST API. To avoid more problems, I would like to discuss the
>> standardization of API modules and create the PIP-142  #14365
>> <https://github.com/apache/pulsar/pull/14365> . Feel free to comment and
>> give suggestions.
>> 
>> 
>> 
>> 
>> Regards
>> Jiwei Guo (Tboy)
>> 

Re: [DISCUSS] PIP-143 : Standardize Admin REST API

Posted by Haiting Jiang <ji...@apache.org>.
+1

Thanks,
Haiting

On 2022/03/16 12:43:45 guo jiwei wrote:
> Hello community,
> 
>     I want to discuss refactoring and standardizing REST API. Users have
> encountered several deadlock problems in the API part before, like #13666
> <https://github.com/apache/pulsar/pull/13666>, #12590
> <https://github.com/apache/pulsar/pull/12590>. After fixing the above two
> issues, we check the related part and find that there are still numbers of
> asynchronous call synchronous implementations for other functions of the
> REST API. To avoid more problems, I would like to discuss the
> standardization of API modules and create the PIP-142  #14365
> <https://github.com/apache/pulsar/pull/14365> . Feel free to comment and
> give suggestions.
> 
> 
> 
> 
> Regards
> Jiwei Guo (Tboy)
>