You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@plc4x.apache.org by GitBox <gi...@apache.org> on 2021/01/10 10:20:26 UTC
[GitHub] [plc4x] hutcheb opened a new pull request #221: Bug/close connection
hutcheb opened a new pull request #221:
URL: https://github.com/apache/plc4x/pull/221
Added call to disconnect when closing a connection.
This allows the connection to wait for the protocol to cleanly disconnect before closing the channel.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [plc4x] hutcheb commented on pull request #221: Bug/close connection
Posted by GitBox <gi...@apache.org>.
hutcheb commented on pull request #221:
URL: https://github.com/apache/plc4x/pull/221#issuecomment-759358520
I agree tests for this class should be implemented, I also agree that it can be handled as a separate issue.
I've added a small amount of logging so it can be traced from Call DisConnectEvent->OnDisconnect->Call DisconnectedEvent->Return.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [plc4x] hutcheb merged pull request #221: Bug/close connection
Posted by GitBox <gi...@apache.org>.
hutcheb merged pull request #221:
URL: https://github.com/apache/plc4x/pull/221
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [plc4x] ottobackwards commented on pull request #221: Bug/close connection
Posted by GitBox <gi...@apache.org>.
ottobackwards commented on pull request #221:
URL: https://github.com/apache/plc4x/pull/221#issuecomment-757626947
+1, I think this is correct.
Two points though.
- It is not good that there are no tests for that, but I don't think that is this PR's responsibility.
- This kind of flow if really difficult to grok and troubleshoot. The complete lack of logging here doesn't help things. But again that is beyond this PR's responsibility
-
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org