You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/07 15:25:04 UTC
[GitHub] [arrow] nealrichardson opened a new pull request #8380: Run fewer CI jobs
nealrichardson opened a new pull request #8380:
URL: https://github.com/apache/arrow/pull/8380
* Only run the pull-request-labeler if the relevant paths are modified and only on opening/reopening a PR
* Cut 2 R builds from the matrix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #8380: ARROW-10217: [CI] Run fewer GitHub Actions jobs
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #8380:
URL: https://github.com/apache/arrow/pull/8380#issuecomment-705059544
@nealrichardson , I think we may have broken master :/ https://github.com/apache/arrow/actions/runs/293834644
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on a change in pull request #8380: ARROW-10217: [CI] Run fewer GitHub Actions jobs
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #8380:
URL: https://github.com/apache/arrow/pull/8380#discussion_r501134986
##########
File path: .github/workflows/dev_labeler.yml
##########
@@ -16,8 +16,10 @@
# under the License.
name: PR labeler
-on:
-- pull_request_target
+on: pull_request_target
+ types: [opened, reopened]
Review comment:
Right, I considered that, but that seems like a relatively rare event, not worth backing up the CI queue with lots of jobs to check labels that will end up being no-op, and something you can fix by clicking close and reopen on the PR. I'm open to being persuaded but this seemed like a good tradeoff.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8380: ARROW-10217: [CI] Run fewer GitHub Actions jobs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8380:
URL: https://github.com/apache/arrow/pull/8380#issuecomment-705033119
https://issues.apache.org/jira/browse/ARROW-10217
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #8380: ARROW-10217: [CI] Run fewer GitHub Actions jobs
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #8380:
URL: https://github.com/apache/arrow/pull/8380#discussion_r501129019
##########
File path: .github/workflows/dev_labeler/labeler.yml
##########
@@ -16,7 +16,7 @@
# under the License.
lang-rust:
- - rust/**/*
+ - rust/**
Review comment:
Is this deliberate?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8380: ARROW-10217: [CI] Run fewer GitHub Actions jobs
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8380:
URL: https://github.com/apache/arrow/pull/8380#issuecomment-705062823
Ok I'll fix, thanks for the heads up
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on a change in pull request #8380: ARROW-10217: [CI] Run fewer GitHub Actions jobs
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on a change in pull request #8380:
URL: https://github.com/apache/arrow/pull/8380#discussion_r501123505
##########
File path: .github/workflows/dev_labeler.yml
##########
@@ -16,8 +16,10 @@
# under the License.
name: PR labeler
-on:
-- pull_request_target
+on: pull_request_target
+ types: [opened, reopened]
Review comment:
When a new push is made to the PR, the labels may change (as new code may change other parts of the code-base, or no longer change other parts). I think that this regresses on that feature.
##########
File path: .github/workflows/dev_labeler/labeler.yml
##########
@@ -16,7 +16,7 @@
# under the License.
lang-rust:
- - rust/**/*
+ - rust/**
Review comment:
I am not sure this will work. At least the [documentation requests](https://github.com/actions/labeler#basic-examples) `**/*`. If you tested and it still works, fine by me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson closed pull request #8380: ARROW-10217: [CI] Run fewer GitHub Actions jobs
Posted by GitBox <gi...@apache.org>.
nealrichardson closed pull request #8380:
URL: https://github.com/apache/arrow/pull/8380
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #8380: ARROW-10217: [CI] Run fewer GitHub Actions jobs
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #8380:
URL: https://github.com/apache/arrow/pull/8380#issuecomment-705063465
I am sorry about that, I should have tested this in my fork before accepting.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on a change in pull request #8380: ARROW-10217: [CI] Run fewer GitHub Actions jobs
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #8380:
URL: https://github.com/apache/arrow/pull/8380#discussion_r501132832
##########
File path: .github/workflows/dev_labeler/labeler.yml
##########
@@ -16,7 +16,7 @@
# under the License.
lang-rust:
- - rust/**/*
+ - rust/**
Review comment:
No, I didn't test, I just saw a bunch of failures from this job so figured I'd try to change this. But now I see that this *is* the fix and you just added this yesterday, so I'll revert.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org